This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add to Cart with Options block: fix inconsistency between editor and frontend #11614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
type: bug
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +16 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
|
Moving to 11.6.0 |
danieldudzic
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Good job, @Aljullu. The PR works correctly and addresses the styling inconsistencies between the editor and front end.
Comment on lines
-1
to
-27
| .wc-block-editor-add-to-cart-form { | ||
| display: flex; | ||
| flex-direction: column; | ||
| row-gap: $default-block-margin; | ||
| } | ||
|
|
||
| input.wc-block-editor-add-to-cart-form__quantity[type="number"] { | ||
| max-width: 50px; | ||
| min-height: 23px; | ||
| float: left; | ||
| padding: 6px 6px 6px 12px; | ||
| margin-right: 10px; | ||
| font-size: 13px; | ||
| height: inherit; | ||
| } | ||
|
|
||
| input[type="number"]::-webkit-inner-spin-button { | ||
| opacity: 1; | ||
| } | ||
|
|
||
| button.components-button.wc-block-add-to-cart-form__button { | ||
| float: left; | ||
| padding: 20px 30px; | ||
| border-radius: 0; | ||
| } | ||
|
|
||
| .wc-block-editor-container { |
There was a problem hiding this comment.
Since some of this code was added to fix: #8582, I'd add a testing step to make sure the button styling is correct both with Gutenberg plugin disabled and enabled.
There was a problem hiding this comment.
Good idea, and thanks for the review!
I updated the testing instructions with this step:
Test with WP 6.3 & Gutenberg disabled and WP 6.4 & Gutenberg enabled (you can use this plugin to update to WP 6.4 before it's released).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11303.
Why
This PR aligns the markup, classes and styles between the editor and the frontend view of the Add to Cart with Options block, to make sure it looks consistent in both views.
Testing Instructions
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog