This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix attempts to count possible non-countable variables or usage of undefined variables #11473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.54 MB ℹ️ View Unchanged
|
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
prettyboymp
added
php
and removed
status: stale
mikejolley
force-pushed
the
rector-php8-fixes
branch
from
c364e9d
to
5c0bd1d
Compare
mikejolley
approved these changes
Nov 8, 2023
…defined variables This fixes a few miscellaneous small problems where a possibly undefined variable was attempted to be accessed or a variable that wasn't necessarily countable was passed to `count()` These were found by running Rector with rules specific to finding issues with php8.
mikejolley
force-pushed
the
rector-php8-fixes
branch
from
5c0bd1d
to
c4be15b
Compare
This was referenced Nov 8, 2023
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes a few miscellaneous small problems where a possibly undefined variable was attempted to be accessed or a variable that wasn't necessarily countable was passed to
count()These were found by running Rector with rules specific to finding issues with php8.
Why
A couple changes are specifically to help a static analysis tool like Rector identify issues. But others are to be sure that fatal errors won't be throw due to changes in functionality between PHP 7.4 and PHP 8.
Testing Instructions
These changes are purely code changes that do not effect functionality.
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog