This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Simplify Product Collection query attributes by removing attributes which are never used #11259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts which are never used
kmanijak
added
skip-changelog
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -3.2 kB (0%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
|
Hey @kmanijak, I noticed that the parents field still exists in the migration scripts: |
Great catch @imanish003, thank you! Fixed! |
imanish003
approved these changes
Oct 18, 2023
Merged
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify Product Collection query attributes by removing attributes (
stickyandparents) that are never used.What
Remove unused attributes from Product Collection query attribute.
Why
Considering we're planning to improve and extend the query attribute it makes sense to clean it up first.
In this PR I'm removing
stickyandparentsattributes which:Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Some testing
Migration
Do not include in the Testing Notes
Should be tested by the development team exclusively
Below Testing instructions are for dev team exclusively
trunkbranchclean/simplify-product-collection-attributes)WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog