This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Temporarily disable the woocommerce-blocks/product-hero-2-col-2-row
pattern
#11234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
October 13, 2023 08:07
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.48 MB ℹ️ View Unchanged
|
albarin
force-pushed
the
disable-pattern
branch
from
October 13, 2023 08:22
83cba9c
to
09706db
Compare
albarin
added
type: enhancement
The issue is a request for an enhancement.
and removed
type: enhancement
The issue is a request for an enhancement.
labels
Oct 13, 2023
tjcafferkey
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Couple of things before merging though:
- Can we update the testing instructions I think you referenced a different pattern it should be
Product Hero 2 Column 2 Row
. - Can we add a changelog to describe the change.
Thanks!
Ooops, fixed! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Temporarily remove the
woocommerce-blocks/product-hero-2-col-2-row
pattern.Why
While testing #11208 we found the pattern was not working as expected, for more context see #11208 (comment)
We'll create a new issue to fix it and re-enable it.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Product Hero 2 Column 2 Row
pattern and confirm it's not available.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog