This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Use the <main> tag in Cart and Checkout templates #11224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavvves
added
type: enhancement
woocommercebot
requested review from
a team and
nielslange
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.48 MB ℹ️ View Unchanged
|
senadir
force-pushed
the
fix/use-main-element-for-cart-and-checkout-templates
branch
from
6b95255
to
322b862
Compare
senadir
deleted the
fix/use-main-element-for-cart-and-checkout-templates
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The cart and checkout templates should use the
<main>HTML element instead of a<div>as the outer wrapper.Fixes #10557
Why
Each template must have one
<main>element.https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/main_role
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Appearance>Editor>Templates>Manage All TemplatesPage: CartandPage: Checkoutdo not have customizations (or delete them if so), and enter edition mode for each oneGroupafter theHeader(Checkout HeaderonPage: Checkouttemplate), openBlock>Advancedpane and ensureHTML ELEMENTis set to<main><main>tagWooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog