This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove order and checkout order endpoints experimental flag #11022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsingyuc
requested review from
a team and
nielslange
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
|
Hi @nielslange! We are hoping to merge this PR for version |
hsingyuc
added
the
type: task
nielslange
reviewed
Sep 25, 2023
There was a problem hiding this comment.
Thank you for your message, @hsingyuc. This is the inaugural request we've received to graduate an experimental flag from someone outside the @woocommerce/rubik and @woocommerce/woo-fse teams. To ensure alignment among our teams regarding the process, I've initiated an internal discussion in p1695394188283659-slack-C02UBB1EPEF.
Upon reviewing the PR, the changes appear sound; however, I’ve identified a couple of points that require attention:
The title employs the term feature flag, yet the modifications in the code reference the experimental flag.The Feature Flags and Experimental Interfaces document continues to enumerate the Experimental flags for both the Order Route (PHP flag) and the Checkout Order Route (PHP flag).
Could you please modify the PR title and update the documents to facilitate a swift merger of the PR once consensus is reached within our teams?
I took care of these two points.
mikejolley
added
the
status: blocker
nielslange
changed the title
nielslange
force-pushed
the
remove/order-endpoint-feature-flag
branch
from
e44d846
to
297e951
Compare
nielslange
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Thanks for working on this, @hsingyuc. I've successfully tested the changes and in p1695631755430759-slack-C02UBB1EPEF, we agreed on graduating these two experimental endpoints. I'll merge this PR now, and it should be shipped with the WooCommerce Blocks 11.2.0 release.
…mmerce/woocommerce-blocks into remove/order-endpoint-feature-flag
This reverts commit 2a6b561.
|
Thank you for your help, @nielslange! |
tarunvijwani
added
the
type: enhancement
|
@hsingyuc Considering these endpoints are now public we should document them under https://github.com/woocommerce/woocommerce-blocks/blob/trunk/src/StoreApi/README.md#resources-and-endpoints. When do you think you could follow up with a PR for this addition? |
|
Thank you for the reminder @ralucaStan! PR opened here #11157 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR removes the experimental flag for the order and checkout order endpoints.
Fixes # N/A
Why
The pay-for-order flow is compatible with WooPay now and is ready to launch so we are ready to remove the experimental flag on the endpoints.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog