This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Image: Fix bug that prevented block styles being applied within the editor. #10859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcafferkey
added
type: bug
tjcafferkey
changed the title
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +7 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
danieldudzic
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Tested, and the fix works great.
I have spotted an unrelated bug, which is also present in the trunk and reported it here: #10862
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the Product Image block so that it applies block styles within the editor such as border radius.
Fixes #10851
Why
The styles were reflected on the frontend, but not on the editor. This means the editor experience was not an accurate representation of the shopping experience.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Products (Beta)andProduct Collections (Beta).Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog