This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix: load blocks style separately for classic themes #10758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
danieldudzic
and removed request for
a team
dinhtungdu
added
status: needs review
type: enhancement
dinhtungdu
requested review from
a team and
mikejolley
and removed request for
a team
|
Requesting a review from @woocommerce/rubik as this PR affects the style of Cart and Checkout blocks. |
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -69.8 kB (-5%) ✅ Total Size: 1.37 MB
ℹ️ View Unchanged
|
opr
previously approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Hi @dinhtungdu looks like styles aren't loading correctly in the editor, I added this block and a few others and noticed it was missing for them all.
No errors in the console though. Also I made a suggestion to make the comment a little better.
opr
dismissed
their stale review
Pressed the wrong button! Just meant to leave a comment
Co-authored-by: Thomas Roberts <[email protected]>
|
@opr Thanks for the review and suggestion. I fixed the style loading in the editor, can you please take another look at this? |
opr
approved these changes
Sep 7, 2023
danielwrobert
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
I tested the list of our blocks on Storefront and smoke-tested a good handful of them in TT3 as well.
All of the styles appeared to load as expected in the Editor and on the frontend of both themes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #10546
For better review experience, you can review only https://github.com/woocommerce/woocommerce-blocks/pull/10758/files/8d0dddb4821ac4a44cf13ba37e1d2ef1699a1dcd..9ad4b0eb0e10f2a10fd9f9a006952203b5950f90.
Why
Because we shouldn't load the unnecessary styles.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Testing this PR means making sure there are no styling regressions in existing blocks for classic themes.
Screenshots or screencast
N/a
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog