This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Fix customer account icon not scaling in certain environments #10533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customer Account block icon size is based on the parent `font-size` in order to make sure they stay harmoniously together. However, the `box-sizing` could be set by some other actor and mess with the size of the icon.
sunyatasattva
added
type: bug
The issue/PR concerns a confirmed bug.
theme: Twenty Twenty-One
block: customer account
Issues related to the Customer account block.
labels
Aug 10, 2023
woocommercebot
requested review from
a team and
danieldudzic
and removed request for
a team
August 10, 2023 15:11
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +68 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
Stale issues and PRs have had no updates for 60 days.
label
Aug 25, 2023
sunyatasattva
removed
the
status: stale
Stale issues and PRs have had no updates for 60 days.
label
Aug 28, 2023
danieldudzic
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: customer account
Issues related to the Customer account block.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Account block icon size is based on the parent
font-size
in order to make sure they stay harmoniously together. However, thebox-sizing
could be set by some other actor and mess with the size of the icon.Fixes #10466
Other Checks
[type]
label or a[skip-changelog]
label.Screenshots
Testing
Automated Tests
User Facing Testing
XL
.WooCommerce Visibility
Changelog