Conversation
As I want to migrate `MediaModel` first in a single PR
And `MediaDao` with AI-generated methods based on `MediaSqlUtils` contract
Replace all usages of `MediaSqlUtils` with `MediaDao`
It's a dead code that previously was used only in tests
Collaborator
Generated by 🚫 Danger |
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
libs/fluxc/src/main/java/org/wordpress/android/fluxc/store/MediaStore.java
Fixed
Show fixed
Hide fixed
Collaborator
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
wzieba
force-pushed
the
migrate_media_model
branch
from
51734c8 to
070ff03
Compare
wzieba
added
the
type: technical debt
Comment out not working tests, update test utilities: tests compile now
…mprove readability
Tests DAO behavior and removes the old `MediaSqlUtilsTest`
`fluxc-tests` is a legacy module, migrated from "sample FluxC app". Unit tests should be placed in the same module as SUT.
This value is actually never used
wzieba
force-pushed
the
migrate_media_model
branch
from
070ff03 to
94db8f3
Compare
Contributor
Author
|
Replaced by #15215 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: AINFRA-542: Migrate
MediaModelDescription
Test Steps
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.