[WOOMOB-1949] Wire file-based sync action and use shared result type by malinajirka · Pull Request #15174 · woocommerce/woocommerce-android

malinajirka · 2026-01-08T13:12:36Z

Fixes WOOMOB-1949

Description

Wires WooPosFileBasedSyncAction into the repository when WOO_POS_LOCAL_CATALOG_FILE_APPROACH feature flag is enabled, and refactors it to return wrapper around PosLocalCatalogSyncResult instead of Result<FileBasedSyncResult>.

This eliminates the need for error mapping in the repository layer - the action now handles all error cases and returns the appropriate PosLocalCatalogSyncResult.Failure types directly (NetworkError, InvalidResponse, DatabaseError, CatalogGenerationTimeout).

Note: There are still a lot of things that need to be done before this code is ready for production. For example:

The 1000 products limit must be removed
Background worker needs to properly handle scenario in which polling runs out of maximum attempts
Checks for catalog size must be skipped when file based approach is enabled
The flag stored in data store for skipping local catalog must be reseted on store with catalog large then 1000 items
....

Test Steps

IMPORTANT - Make sure to use supported version of Woo on your site. You can use Jetpack Beta plugin and select issue/woomob-1894-add-pos-visibility-taxonomy-to-core branch of Woo core.

Test file-based sync (new behavior):

Enable WOO_POS_LOCAL_CATALOG_FILE_APPROACH feature flag
Clear app data
Log in
Observer network requests and verify the file is downloaded and incremental update fetches just first page with 0 results.
Open POS and verify products are visible

Test for regressions (paginated sync):

Disable WOO_POS_LOCAL_CATALOG_FILE_APPROACH feature flag
Clear app data
Log in and open POS
Verify products load successfully

Images/gif

N/A - Internal sync logic changes

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

…and-paginated-download' into issue/woomob-1949-poslocal-catalog-switch-between-file-and-paginated-download # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/localcatalog/WooPosFileBasedSyncAction.kt # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/woopos/localcatalog/WooPosFileBasedSyncActionTest.kt

…etween-file-and-paginated-download # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/localcatalog/WooPosFileBasedSyncAction.kt

…and-paginated-download' into issue/woomob-1949-poslocal-catalog-switch-between-file-and-paginated-download # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/localcatalog/WooPosFileBasedSyncAction.kt

wpmobilebot · 2026-01-08T13:17:47Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`f3424a8`
	Direct Download	`woocommerce-wear-prototype-build-pr15174-f3424a8.apk`

wpmobilebot · 2026-01-08T13:31:05Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`f3424a8`
	Direct Download	`woocommerce-prototype-build-pr15174-f3424a8.apk`

Copilot

Pull request overview

This PR wires the WooPosFileBasedSyncAction into the WooPosLocalCatalogSyncRepository and refactors it to return PosLocalCatalogSyncResult directly instead of wrapping results in Result<FileBasedSyncResult>. This eliminates error mapping at the repository level and makes the file-based sync action consistent with the existing paginated sync action.

Key changes:

Feature flag-based conditional routing between file-based and paginated sync approaches
Direct return of PosLocalCatalogSyncResult types with specific failure subtypes (NetworkError, InvalidResponse, DatabaseError, CatalogGenerationTimeout)
Removal of intermediate FileBasedSyncResult data class

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
`WooPosLocalCatalogSyncRepository.kt`	Added dependency injection for `WooPosFileBasedSyncAction` and feature flag-based conditional logic to route sync requests
`WooPosFileBasedSyncAction.kt`	Refactored return type from `Result<FileBasedSyncResult>` to `PosLocalCatalogSyncResult` with improved error handling and logging consistency
`WooPosFileBasedSyncActionTest.kt`	Updated test assertions to match new return type, removed obsolete test for fields no longer in the result
`WooPosLocalCatalogSyncRepositoryTest.kt`	Added mock for `WooPosFileBasedSyncAction`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.../src/main/kotlin/com/woocommerce/android/ui/woopos/localcatalog/WooPosFileBasedSyncAction.kt

…localcatalog/WooPosFileBasedSyncAction.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

codecov-commenter · 2026-01-08T15:17:41Z

Codecov Report

❌ Patch coverage is 74.32432% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.65%. Comparing base (1b570f5) to head (f3424a8).
⚠️ Report is 10 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...s/localcatalog/WooPosLocalCatalogSyncRepository.kt	36.84%	11 Missing and 1 partial ⚠️
...i/woopos/localcatalog/WooPosFileBasedSyncAction.kt	87.27%	0 Missing and 7 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##              trunk   #15174   +/-   ##
=========================================
  Coverage     38.65%   38.65%           
  Complexity    10520    10520           
=========================================
  Files          2189     2189           
  Lines        124369   124400   +31     
  Branches      17189    17196    +7     
=========================================
+ Hits          48069    48091   +22     
- Misses        71449    71455    +6     
- Partials       4851     4854    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-09T19:36:16Z

...otlin/com/woocommerce/android/ui/woopos/localcatalog/WooPosLocalCatalogSyncRepositoryTest.kt

 class WooPosLocalCatalogSyncRepositoryTest : BaseUnitTest() {
    private lateinit var sut: WooPosLocalCatalogSyncRepository
    private var posSyncAction: WooPosSyncAction = mock()
+    private var posFileBasedSyncAction: WooPosFileBasedSyncAction = mock()


The new file-based sync path added to syncLocalCatalogFull when the feature flag is enabled lacks test coverage. Consider adding test cases that verify:

The file-based sync action is called when the feature flag is enabled

Timestamps are properly stored from the lastModifiedDate when file-based sync succeeds

Failure scenarios from file-based sync are properly handled

The regular paginated sync is still used when the feature flag is disabled

…etween-file-and-paginated-download

samiuelson

LGTM!

malinajirka added 6 commits January 7, 2026 09:28

Remove fileUrl from the result

a88751c

Refactor WooPosFileBasedSyncAction to use shared result type

dcd6f43

Wire WooPosFileBasedSyncAction when FF enabled

b9873d9

Merge branch 'trunk' into issue/woomob-1949-poslocal-catalog-switch-b…

da54348

…etween-file-and-paginated-download # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/localcatalog/WooPosFileBasedSyncAction.kt

Base automatically changed from issue/woomob-1945-poslocal-catalog-switch-between-file-and-paginated-download to trunk January 8, 2026 13:38

malinajirka added this to the 24.0 milestone Jan 8, 2026

malinajirka added the feature: POS label Jan 8, 2026

malinajirka requested a review from Copilot January 8, 2026 14:32

Copilot started reviewing on behalf of malinajirka January 8, 2026 14:32 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

.../src/main/kotlin/com/woocommerce/android/ui/woopos/localcatalog/WooPosFileBasedSyncAction.kt Outdated Show resolved Hide resolved

Update WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/…

4191e47

…localcatalog/WooPosFileBasedSyncAction.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Set last sync timestamps for file based sync

50b0e03

malinajirka requested a review from samiuelson January 8, 2026 16:30

samiuelson self-assigned this Jan 9, 2026

samiuelson requested a review from Copilot January 9, 2026 19:33

Copilot started reviewing on behalf of samiuelson January 9, 2026 19:33 View session

Copilot AI reviewed Jan 9, 2026

View reviewed changes

Merge branch 'trunk' into issue/woomob-1949-poslocal-catalog-switch-b…

f3424a8

…etween-file-and-paginated-download

samiuelson approved these changes Jan 12, 2026

View reviewed changes

samiuelson enabled auto-merge January 12, 2026 20:08

samiuelson merged commit 7dc21fc into trunk Jan 12, 2026
16 of 17 checks passed

samiuelson deleted the issue/woomob-1949-poslocal-catalog-switch-between-file-and-paginated-download branch January 12, 2026 20:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WOOMOB-1949] Wire file-based sync action and use shared result type#15174

[WOOMOB-1949] Wire file-based sync action and use shared result type#15174
samiuelson merged 9 commits intotrunkfrom
issue/woomob-1949-poslocal-catalog-switch-between-file-and-paginated-download

malinajirka commented Jan 8, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Jan 8, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Jan 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

codecov-commenter commented Jan 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 9, 2026

Uh oh!

samiuelson left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

malinajirka commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Steps

Images/gif

Uh oh!

wpmobilebot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

codecov-commenter commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

samiuelson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

malinajirka commented Jan 8, 2026 •

edited

Loading

wpmobilebot commented Jan 8, 2026 •

edited

Loading

wpmobilebot commented Jan 8, 2026 •

edited

Loading

codecov-commenter commented Jan 8, 2026 •

edited

Loading