[WOOMOB-1854] WooPos Card Reader Connection UI #15063
Draft
+1,726
−326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the core business logic for WooPos card reader connection: - WooPosCardReaderConnectionState sealed interface with all connection states - WooPosCardReaderConnectionController handling discovery and connection flow - WooPosCardReaderConnectionControllerFactory for dependency injection
Introduces the UI layer for WooPos card reader connection: - WooPosCardReaderConnectionViewModel for state management - WooPosCardReaderConnectionDialog Compose UI with all connection states - Updated WooPosUpdateProgressIndicator to match iOS design (solid fill) - String resources for connection UI
Replaces Activity-based card reader connection with Compose dialog: - Remove WooPosCardReaderActivity and its layout - Update WooPosCardReaderFacade to use ChildToParentEvent - Add ShowCardReaderConnectionDialog event to home and settings - Update ViewModels to trigger connection dialog - Update tests for new flow
Cleans up WooPos references from the payments cardreader module: - Remove CardReaderFlowParam.WooPosConnection - Remove ReturnToWooPos event - Remove pointOfSalePaymentsFlowTracker injection - Simplify CardReaderConnectViewModel and related classes
Collaborator
Generated by 🚫 Danger |
kidinov
changed the title
kidinov
changed the base branch from
trunk
to
hack-week/adaptive-layout-coupons-test-deps
kidinov
changed the base branch from
hack-week/adaptive-layout-coupons-test-deps
to
hackweek-margins-adaptation
Collaborator
Project manifest changes for WooCommerceThe following changes in the --- ./build/reports/diff_manifest/WooCommerce/vanillaRelease/base_manifest.txt 2025-12-05 09:26:16.502516639 +0000
+++ ./build/reports/diff_manifest/WooCommerce/vanillaRelease/head_manifest.txt 2025-12-05 09:26:19.692501375 +0000
@@ -218,10 +218,6 @@
android:theme="@style/Theme.WooPos"
android:windowSoftInputMode="adjustResize" />
<activity
- android:name="com.woocommerce.android.ui.woopos.cardreader.WooPosCardReaderActivity"
- android:theme="@style/Theme.WooPos.Transparent"
- android:windowSoftInputMode="adjustResize" />
- <activity
android:name="com.woocommerce.android.ui.woopos.home.items.coupons.creation.WooPosCouponCreationActivity"
android:theme="@style/Theme.WooPos.DayNight.Transparent"
android:windowSoftInputMode="adjustResize" /> <!-- Stats today app widget -->Go to https://buildkite.com/automattic/woocommerce-android/builds/34247/canvas?sid=019aedd1-5801-4ab8-b7a2-52363a043b4f, click on the |
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Collaborator
🤖 Test Failure AnalysisYour tests failed. Claude has analyzed the failures - check the annotation for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.