[HACK] Add auto-login universal link for debug builds #15062

kidinov · 2025-12-05T04:28:24Z

Description

Adds support for a universal link that allows automatic login using application password credentials in debug builds. This is useful for developer and testing workflows.

URL Format:

https://woocommerce.com/mobile/auto-login?site=<encoded_site_url>&user=<username>&password=<app_password>

Example (with placeholder credentials):

adb shell "am start -a android.intent.action.VIEW -d 'https://woocommerce.com/mobile/auto-login?site=https%3A%2F%2Fexample.com&user=testuser&password=xxxx-xxxx-xxxx-xxxx'"

Behavior:

Debug builds only (intent filter in debug manifest)
If already logged in, navigates directly to main screen
On success, navigates to main screen
On error, shows toast and opens login screen

Do not merge, as I am not sure how valuable this is for anyone so I firstly would like to ask

Test Steps

Install debug build
Clear app data to ensure logged out state
Run the adb command above with valid site credentials
Verify the app logs in and navigates to the main screen

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

dangermattic · 2025-12-05T04:29:23Z

	2 Errors
🚫	Please add tests for class `AutoLoginHandler` (or add `unit-tests-exemption` label to ignore this).
🚫	This PR is tagged with `status: do not merge` label(s).

Generated by 🚫 Danger

wpmobilebot · 2025-12-05T04:33:13Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`6114afb`
	Direct Download	`woocommerce-wear-prototype-build-pr15062-6114afb.apk`

wpmobilebot · 2025-12-05T04:46:38Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`6114afb`
	Direct Download	`woocommerce-prototype-build-pr15062-6114afb.apk`

Copilot

Pull request overview

This PR adds a debug-only auto-login feature via universal link to streamline developer and testing workflows. The feature allows automatic login using application password credentials through a specially formatted URL.

Key Changes:

Adds AutoLoginHandler to process auto-login requests and validate credentials
Adds AutoLoginActivity to handle the universal link intent and coordinate the login flow
Registers the auto-login deep link in the debug manifest with intent filter

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
`AutoLoginHandler.kt`	Core logic for parsing credentials from URI, validating site/user eligibility, and managing login state
`AutoLoginActivity.kt`	Activity that handles the auto-login universal link intent and navigates to appropriate screens based on success/failure
`AndroidManifest.xml`	Registers the auto-login activity with intent filter for `woocommerce.com/mobile/auto-login` path (debug builds only)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-05T06:55:23Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/login/auto/AutoLoginHandler.kt

+                    },
+                    onFailure = { exception ->
+                        WooLog.e(WooLog.T.LOGIN, "AutoLoginHandler: Failed to check user eligibility", exception)
+                        AutoLoginResult.Error("Failed to verify user: ${exception.message}")


The fold operation on eligibilityResult doesn't return a value in the onFailure branch. This will cause a compilation error because the outer fold expects a return value.

Add return@withContext before the AutoLoginResult.Error:

onFailure = { exception -> WooLog.e(WooLog.T.LOGIN, "AutoLoginHandler: Failed to check user eligibility", exception) return@withContext AutoLoginResult.Error("Failed to verify user: ${exception.message}") }

Suggested change

AutoLoginResult.Error("Failed to verify user: ${exception.message}")

return@withContext AutoLoginResult.Error("Failed to verify user: ${exception.message}")

Copilot · 2025-12-05T06:55:23Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/login/auto/AutoLoginHandler.kt

+            },
+            onFailure = { exception ->
+                WooLog.e(WooLog.T.LOGIN, "AutoLoginHandler: Failed to fetch site", exception)
+                AutoLoginResult.Error("Failed to connect to site: ${exception.message}")


The fold operation on fetchSiteResult doesn't return a value in the onFailure branch. This will cause a compilation error.

Add return@withContext before the AutoLoginResult.Error:

onFailure = { exception -> WooLog.e(WooLog.T.LOGIN, "AutoLoginHandler: Failed to fetch site", exception) return@withContext AutoLoginResult.Error("Failed to connect to site: ${exception.message}") }

Suggested change

AutoLoginResult.Error("Failed to connect to site: ${exception.message}")

return@withContext AutoLoginResult.Error("Failed to connect to site: ${exception.message}")

Copilot · 2025-12-05T06:55:23Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/login/auto/AutoLoginHandler.kt

+        val fetchSiteResult = wpApiSiteRepository.fetchSite(
+            url = siteUrl,
+            username = username,
+            password = password
+        )


Credentials (username and password) are being logged or could be exposed in error messages. Even though this is a debug-only feature, credentials should not be logged. The current implementation doesn't directly log credentials, but if any of the underlying repository methods log the parameters, sensitive information could be exposed.

Consider adding a comment or documentation noting that the underlying repository methods should not log credentials, or sanitize error messages to ensure they don't inadvertently include sensitive data.

Copilot · 2025-12-05T06:55:24Z

WooCommerce/src/debug/AndroidManifest.xml

+            android:name=".ui.login.auto.AutoLoginActivity"
+            android:exported="true"
+            android:theme="@style/Theme.Woo.Splash">
+            <intent-filter android:autoVerify="true">


The autoVerify="true" attribute on the intent filter is unnecessary for this debug-only feature and could cause confusion. Auto-verification is used for App Links to verify domain ownership via a Digital Asset Links file, which is not needed for a debug testing tool.

Consider removing android:autoVerify="true" from the intent filter:

<intent-filter>

Suggested change

<intent-filter android:autoVerify="true">

<intent-filter>

@kidinov This seems like a valid point, wdyt?

Copilot · 2025-12-05T06:55:24Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/login/auto/AutoLoginHandler.kt

+                        selectedSite.set(site)
+
+                        WooLog.d(WooLog.T.LOGIN, "AutoLoginHandler: Login successful")
+                        AutoLoginResult.Success


The login function doesn't return a value in all code paths. When eligibilityResult.fold succeeds and the user is eligible, AutoLoginResult.Success is created but not returned. This will cause a compilation error.

Add return@withContext before AutoLoginResult.Success to fix this:

return@withContext AutoLoginResult.Success

Suggested change

AutoLoginResult.Success

return@withContext AutoLoginResult.Success

malinajirka

It looks good to me overall, however, I'm not sure whether it's a good idea to have it. Especially, if we decide to stop doing smoke tests before each release, I think there is a value in going through the login flow during development. If we had to login after each change, that would be too much hassle, but we need to login just when we are testing something specific. Having said all that, I'm good with merging it.

malinajirka · 2025-12-05T09:30:39Z

WooCommerce/src/debug/AndroidManifest.xml

+            android:name=".ui.login.auto.AutoLoginActivity"
+            android:exported="true"
+            android:theme="@style/Theme.Woo.Splash">
+            <intent-filter android:autoVerify="true">


@kidinov This seems like a valid point, wdyt?

kidinov added 2 commits December 5, 2025 12:27

Add auto-login universal link support for debug builds

713c7d0

Register AutoLoginActivity intent filter in debug manifest

6114afb

kidinov added Hack Week feature: login Related to any part of the log in or sign in flow, or authentication. labels Dec 5, 2025

kidinov changed the title ~~[Internal] Add auto-login universal link for debug builds~~ [HACK] Add auto-login universal link for debug builds Dec 5, 2025

kidinov added this to the 23.9 milestone Dec 5, 2025

kidinov added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Dec 5, 2025

kidinov requested review from Copilot and malinajirka December 5, 2025 06:52

kidinov marked this pull request as ready for review December 5, 2025 06:53

Copilot started reviewing on behalf of kidinov December 5, 2025 06:53 View session

Copilot finished reviewing on behalf of kidinov December 5, 2025 06:54

Copilot AI reviewed Dec 5, 2025

View reviewed changes

malinajirka approved these changes Dec 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[HACK] Add auto-login universal link for debug builds #15062

[HACK] Add auto-login universal link for debug builds #15062

kidinov commented Dec 5, 2025 •

edited

Loading

Uh oh!

dangermattic commented Dec 5, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Dec 5, 2025

Uh oh!

wpmobilebot commented Dec 5, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 5, 2025

Uh oh!

Copilot AI Dec 5, 2025

Uh oh!

Copilot AI Dec 5, 2025

Uh oh!

Copilot AI Dec 5, 2025

Uh oh!

malinajirka Dec 5, 2025

Uh oh!

Copilot AI Dec 5, 2025

Uh oh!

malinajirka left a comment

Uh oh!

malinajirka Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	AutoLoginResult.Error("Failed to verify user: ${exception.message}")
	return@withContext AutoLoginResult.Error("Failed to verify user: ${exception.message}")

	AutoLoginResult.Error("Failed to connect to site: ${exception.message}")
	return@withContext AutoLoginResult.Error("Failed to connect to site: ${exception.message}")

	AutoLoginResult.Success
	return@withContext AutoLoginResult.Success

[HACK] Add auto-login universal link for debug builds #15062

Are you sure you want to change the base?

[HACK] Add auto-login universal link for debug builds #15062

Conversation

kidinov commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Steps

Uh oh!

dangermattic commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Dec 5, 2025

Uh oh!

wpmobilebot commented Dec 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

malinajirka Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

malinajirka left a comment

Choose a reason for hiding this comment

Uh oh!

malinajirka Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kidinov commented Dec 5, 2025 •

edited

Loading

dangermattic commented Dec 5, 2025 •

edited

Loading