[HACK][Woo POS] Make WooPosSpacing automatically adaptive #15060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed WooPosSpacing enum so that .value is now a composable getter that automatically applies toAdaptivePadding(). This makes all spacing adaptive by default without requiring manual calls. For ConstraintLayout usages, extracted margin values before the constrainAs lambda since it's not a composable context.
Since WooPosSpacing.value is now adaptive by default, removed redundant .toAdaptivePadding() calls on WooPosSpacing values and cleaned up unused imports across WooPos screens.
Collaborator
Generated by 🚫 Danger |
kidinov
changed the title
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #15060 +/- ##
============================================
- Coverage 38.66% 38.66% -0.01%
+ Complexity 10362 10361 -1
============================================
Files 2168 2168
Lines 123004 123015 +11
Branches 16977 16978 +1
============================================
- Hits 47561 47560 -1
- Misses 70638 70649 +11
- Partials 4805 4806 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersDetails.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes
WooPosSpacing.valueautomatically return adaptive padding based on screen size, eliminating the need for manual.toAdaptivePadding()calls throughout the codebase.Changes:
WooPosSpacingenum to have a composable getter that automatically applies adaptive scalingXXSmall(2dp),XXLarge(40dp),XXXLarge(48dp),Huge(80dp),Gigantic(104dp)WooPosSpacingvalues.toAdaptivePadding()calls and cleaned up unused importsNote: Some spacing values are mapped to the closest available enum value (e.g., 56dp → 48dp, 96dp → 80dp), so minor visual differences may be visible compared to before.
Test Steps
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.