-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fourth MC Setup step value: 'store_requirements' #928
Conversation
04a1205
to
56a91ff
Compare
56a91ff
to
8d76e77
Compare
…end took the same one. Refer to #928
@eason9487 can you check if this works for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the PHP code that I can't evaluate, I tested this PR yesterday by changing the settings in step 3, and all logic works correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, added two comments.
Changes proposed in this Pull Request:
Goes with #927 .
This adds a fourth
step
value to the possible replies fromGET /wc/gla/mc/step
:store_requirements
.This value is returned when shipping rate, shipping time, tax rate and free shipping threshold values are all deemed to have been completed:
tax_rate
setting isn't emptyoffers_free_shipping
isfalse
), or offered andfree_shipping_threshold
set (can be0
, just not null)shipping_rate
setting set tomanual
OR one row inwp_gla_shipping_rates
table for each target countryDetailed test instructions:
GET /gla/mc/setup
request and confirm that thestep
value is as expectedstore_requirements
shipping_and_taxes
store_requirements
shipping_and_taxes
store_requirements
shipping_and_taxes
0
🤷🏻 ):store_requirements
(Changelog added with frontend changes).
Changelog entry