Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the pre-launch checklist from step 3 to 4 for the MC setup #927

Merged
merged 5 commits into from
Aug 4, 2021
Merged

Move the pre-launch checklist from step 3 to 4 for the MC setup #927

merged 5 commits into from
Aug 4, 2021

Commits on Aug 2, 2021

  1. Move PreLaunchChecklist and related code out from the step 3 of MC setup

    @eason9487
    eason9487 committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    1f649ff View commit details
    Browse the repository at this point in the history

  2. Add PreLaunchChecklist to the step 4 of MC setup

    @eason9487
    eason9487 committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    5c3fa22 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. Hold rendering before settings data loaded for StoreRequirements

    @eason9487
    eason9487 committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    770e03d View commit details
    Browse the repository at this point in the history

  2. Split tests of unset value and invalid value. 

    Address #927 (comment)
    @eason9487
    eason9487 committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    0c9bd95 View commit details
    Browse the repository at this point in the history

  3. Refactor …/pre-launch-checklist/checkErrors.test.js . 

    Make descriptions more descriptive, remove unused parameters,
remove snapshots.
    @tomalec
    tomalec committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    7879f75 View commit details
    Browse the repository at this point in the history