Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the giant icon problem in the warning messages #528

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

This problem was discovered in #527.

image

Root cause

Libraries depend on a different version of @wordpress/icons, causing the react component instance checking icon.type === SVG to get false result.

https://github.com/WordPress/gutenberg/blob/%40wordpress/components%4012.0.8/packages/components/src/icon/index.js#L41-L50

Solution

Upgrade @wordpress/icons to the same version used in @wordpress/components.

Screenshots:

image

Detailed test instructions:

  1. npm install and restart dev build npm start
  2. Set the store location to “South Sudan” in WooCommerce → Settings
  3. Head to the Get Started page and the external link icon should be displayed with a proper size.

@eason9487 eason9487 requested a review from a team April 28, 2021 11:20
@eason9487 eason9487 self-assigned this Apr 28, 2021
Copy link
Member

@tomalec tomalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

@eason9487 eason9487 merged commit b090d6a into trunk Apr 29, 2021
@eason9487 eason9487 deleted the fix/giant-icon branch April 29, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants