Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect MC Account within combo card #2639

Draft
wants to merge 53 commits into
base: feature/2567-kickoff-mc-ads-account-creation
Choose a base branch
from
Draft

Connect MC Account within combo card #2639

wants to merge 53 commits into from

Commits on Aug 19, 2024

  1. Hide Tax UI during onboarding & keep in edit campaign

    @dsawardekar
    dsawardekar committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7ccf37f View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Removes tax rate related e2e tests since no onboarding UI

    @dsawardekar
    dsawardekar committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f3d0847 View commit details
    Browse the repository at this point in the history

  2. Fixes linter warnings

    @dsawardekar
    dsawardekar committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    87d46c2 View commit details
    Browse the repository at this point in the history

  3. Fixes linter warnings

    @dsawardekar
    dsawardekar committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    98aa6f0 View commit details
    Browse the repository at this point in the history

  4. Removes unused code in e2e tests

    @dsawardekar
    dsawardekar committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d8d0ba9 View commit details
    Browse the repository at this point in the history

  5. Removes extra line break

    @dsawardekar
    dsawardekar committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7acafdf View commit details
    Browse the repository at this point in the history

  6. Merge branch 'tweak/default-tax-2491' into update/2490-hide-tax-rate-… 

    …selection-ui-onboarding
    @dsawardekar
    dsawardekar committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    57ecc5d View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Hide default prop per CR feedback

    @dsawardekar
    dsawardekar committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9cd398f View commit details
    Browse the repository at this point in the history

  2. Update error checking to ignore if hideTaxRates is true

    @dsawardekar
    dsawardekar committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    a4abb29 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Mock default MC settings with tax_rate set

    @joemcgill
    joemcgill committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c2c3242 View commit details
    Browse the repository at this point in the history

  2. Remove unused e2e test helpers

    @joemcgill
    joemcgill committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4870093 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge branch 'update/2490-hide-tax-rate-selection-ui-onboarding' of g… 

    …ithub.com:woocommerce/google-listings-and-ads into update/2490-hide-tax-rate-selection-ui-onboarding
    @dsawardekar
    dsawardekar committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    debc575 View commit details
    Browse the repository at this point in the history

  2. Removes unused function

    @dsawardekar
    dsawardekar committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    630c73d View commit details
    Browse the repository at this point in the history

  3. Updates props per CR feedback

    @dsawardekar
    dsawardekar committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    3e4910f View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Updates jsdoc

    @dsawardekar
    dsawardekar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5db0bad View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/2458-streamline-onboarding' into update/2490-hi… 

    …de-tax-rate-selection-ui-onboarding
    @dsawardekar
    dsawardekar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    bd39f03 View commit details
    Browse the repository at this point in the history

  3. First pass at appselectcontrol changes

    @dsawardekar
    dsawardekar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e7e6687 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Fix linter warnings

    @dsawardekar
    dsawardekar committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3b87196 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge pull request #2542 from woocommerce/update/2490-hide-tax-rate-s… 

    …election-ui-onboarding

Hide Tax UI during onboarding & keep in edit campaign
    @joemcgill
    joemcgill authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    8eb1fff View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Move AdsAccountSelectControl

    @asvinb
    asvinb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5ab1b61 View commit details
    Browse the repository at this point in the history

  2. Update Jest tests.

    @asvinb
    asvinb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2fb0353 View commit details
    Browse the repository at this point in the history

  3. Update label.

    @asvinb
    asvinb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    fd9f50a View commit details
    Browse the repository at this point in the history

  4. Fix e2e tests.

    @asvinb
    asvinb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a17ce78 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Do not use translation.

    @asvinb
    asvinb committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6342061 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Merge branch 'feature/2458-streamline-onboarding' into update/2593-up… 

    …date-app-select-control-single-select
    @asvinb
    asvinb committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f0e12a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Tweak WP Proxy Response to force the types of the fields

    @puntope
    puntope committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a37c974 View commit details
    Browse the repository at this point in the history

  2. Symlink WC instead of moving the WC folder

    @jorgemd24
    jorgemd24 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7cb7531 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Fix mixed spacing

    @jorgemd24
    jorgemd24 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2583950 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2625 from woocommerce/dev/fix-bluebird-dependency… 

    …-issue

PHP Units tests: Symlink WC instead of moving the WC folder
    @jorgemd24
    jorgemd24 authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    24c212e View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Merge branch 'develop' into fix/api-pull-type-prices

    @puntope
    puntope committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    502a89e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2624 from woocommerce/fix/api-pull-type-prices 

    [API PULL] Tweak WP Proxy Response to force the types of the price fields
    @puntope
    puntope authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c93a26a View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Move auto select logic to AppSelectControl.

    @asvinb
    asvinb committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d575ba6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/2458-streamline-onboarding

    @joemcgill
    joemcgill committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a2a1e84 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/2458-streamline-onboarding' into feature/2590-c… 

    …onsolidate-google-account-cards
    @joemcgill
    joemcgill committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    345e6b1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/2509-consolidate-google-account-cards' into upd… 

    …ate/2593-update-app-select-control-single-select
    @joemcgill
    joemcgill authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    dc9b152 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Address CR feedback.

    @asvinb
    asvinb committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0eafa45 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Use useRef to prevent re renders.

    @asvinb
    asvinb committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8c43ac6 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Save WIP.

    @asvinb
    asvinb committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    874ef00 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/2567-kickoff-mc-ads-account-creation' into upda… 

    …te/2597-connect-mc-account
    @asvinb
    asvinb committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    1ead7f9 View commit details
    Browse the repository at this point in the history

  3. Extract DisconnectAccount button.

    @asvinb
    asvinb committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    4428639 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Add ConnectAccountCard component.

    @asvinb
    asvinb committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    bebfaed View commit details
    Browse the repository at this point in the history

  2. Add ConnectMCBody and ConnectMCFooter component.

    @asvinb
    asvinb committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    872787e View commit details
    Browse the repository at this point in the history

  3. Check for undefined values.

    @asvinb
    asvinb committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    004c9f6 View commit details
    Browse the repository at this point in the history

  4. Make better use of useRef.

    @asvinb
    asvinb committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    08b16e0 View commit details
    Browse the repository at this point in the history

  5. Updated JSDocs.

    @asvinb
    asvinb committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f290352 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Fix JSDocs.

    @asvinb
    asvinb committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d8f3ed9 View commit details
    Browse the repository at this point in the history

  2. Save WIP.

    @asvinb
    asvinb committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9475ec2 View commit details
    Browse the repository at this point in the history

  3. Check for non connected state.

    @asvinb
    asvinb committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3965234 View commit details
    Browse the repository at this point in the history

  4. Add preConditionReady check.

    @asvinb
    asvinb committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8a4ba4c View commit details
    Browse the repository at this point in the history

  5. Revert dev temp changes.

    @asvinb
    asvinb committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8b850fd View commit details
    Browse the repository at this point in the history

  6. Merge pull request #2608 from woocommerce/update/2593-update-app-sele… 

    …ct-control-single-select

2593: Update AppSelectControl to single select
    @asvinb
    asvinb authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    7d31e5c View commit details
    Browse the repository at this point in the history

  7. Save E2E tests,

    @asvinb
    asvinb committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    176a4a8 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'feature/2509-consolidate-google-account-cards' into upd… 

    …ate/2597-connect-mc-account
    @asvinb
    asvinb committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b4b4347 View commit details
    Browse the repository at this point in the history