Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.8.6 #2636

Merged
merged 15 commits into from
Oct 2, 2024
Merged

Release 2.8.6 #2636

merged 15 commits into from
Oct 2, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 2, 2024

Checklist

  1. Check if the version, base, and target branches are as you desire.
  2. Make sure you have woorelease installed and set up.
  3. Go to your local repo clone, and check out this PR to be able to commit any potential adjustments.
    git fetch origin release/2.8.6
    git checkout release/2.8.6
  4. Remove older changelog entries from readme.txt (keep the last two versions, since we will be adding a third during the release), commit changes.
  5. If there are new database migration classes (under src/DB/Migration/), modify their applicable version set in the get_applicable_version class of each migration class to be the same value as the version that is to be released.
    ⚠️ Notice that x.x.x is not a valid version and should be set manually with the new version. So, for example, if we are releasing version 1.12.0 and there is a file Migration20211228T1640692399.php inside src/DB/Migration/, you should open that file and in the method get_applicable_version return 1.12.0.
  6. ❗ If this release has updated composer packages, we should test Composer package conflicts with other plugins.
  7. Simulate the release locally
    woorelease simulate --product_version=2.8.6  --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.8.6
    Note: Select y when prompted: "Would you like to add/delete them in the svn working copy?"
  8. The changelog is correct.
    Check if some entries are missing, need rewording, or need to be deleted. You can edit respective PRs by changing their title, ### Changelog entry section, or assigning the changelog: none label.
    You can also edit the changelog manually in the woorelease release step later.
  9. Automated tests are passing.
  10. Test the package
    1. Install the /tmp/google-listings-and-ads.zip file on a test site
    2. Confirm it activates without warnings/errors and is showing the right versions
    3. Run a few basic smoke tests

Next steps

  1. Do the final release
    woorelease release --product_version=2.8.6   --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.8.6
    
    When prompted for changelog entries, double-check and apply any changes if needed.
  2. Confirm the release using the activation link from your email.
    When releasing to WordPress.org, “release notifications” have been enabled, so each committer will be sent an email with an action link to confirm the release. This must be done after committing in SVN before the release becomes available. See the following page for releases pending notifications: https://wordpress.org/plugins/developers/releases/
  3. Go to https://github.com/woocommerce/google-listings-and-ads/releases/2.8.6, generate GitHub release notes, and paste them as a comment here.
  4. Merge this PR after the new release is successfully created and the version tags are updated.
  5. Merge trunk to develop (PR), if applicable for this repo.
  6. Update documentation
    • Publish any new required docs
    • Update triggers/rules/actions listing pages
  7. Mark related ideas complete on the feature requests page.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.3%. Comparing base (6c6002c) to head (364e590).

Files with missing lines Patch % Lines
src/Integration/WPCOMProxy.php 60.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             trunk   #2636     +/-   ##
=========================================
+ Coverage     64.7%   65.3%   +0.6%     
  Complexity    4596    4596             
=========================================
  Files          793     474    -319     
  Lines        22967   17896   -5071     
  Branches      1231       0   -1231     
=========================================
- Hits         14865   11688   -3177     
+ Misses        7929    6208   -1721     
+ Partials       173       0    -173     
Flag Coverage Δ
js-unit-tests ?
php-unit-tests 65.3% <75.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Product/SyncerHooks.php 90.0% <100.0%> (ø)
src/Integration/WPCOMProxy.php 74.8% <60.0%> (+0.7%) ⬆️

... and 319 files with indirect coverage changes

@tomalec
Copy link
Member

tomalec commented Oct 2, 2024

@tomalec
Copy link
Member

tomalec commented Oct 2, 2024

  • Dev - Fix missing blueprint dependency.
  • Tweak - Adjust WP Proxy Response to force the string type for the price fields.
  • Tweak - Logic for Delete notifications.

What's Changed

[Fix] Fixes 🛠

[Dev] Developer-facing changes 🧑‍💻

Full Changelog: 2.8.5...2.8.6

@tomalec tomalec merged commit dffee9c into trunk Oct 2, 2024
@tomalec tomalec deleted the release/2.8.6 branch October 2, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants