Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge onboarding improvements branch into consolidated ad #2627

Merged
merged 202 commits into from
Sep 30, 2024

fix linting issues.

5d727ba
Select commit
Loading
Failed to load commit list.
Merged

Merge onboarding improvements branch into consolidated ad #2627

fix linting issues.
5d727ba
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 27, 2024 in 0s

61.0% (-1.1%) compared to 5343963

View this Pull Request on Codecov

61.0% (-1.1%) compared to 5343963

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 45 lines in your changes missing coverage. Please review.

Project coverage is 61.0%. Comparing base (5343963) to head (5d727ba).

Files with missing lines Patch % Lines
...src/components/paid-ads/asset-group/asset-group.js 0.0% 12 Missing ⚠️
js/src/components/app-tooltip/index.js 50.0% 3 Missing and 1 partial ⚠️
js/src/components/tree-select-control/index.js 71.4% 3 Missing and 1 partial ⚠️
...ute-mapping/attribute-mapping-delete-rule-modal.js 0.0% 1 Missing and 1 partial ⚠️
.../attribute-mapping/attribute-mapping-rule-modal.js 50.0% 1 Missing and 1 partial ⚠️
.../free-listings/setup-free-listings/form-content.js 0.0% 1 Missing and 1 partial ⚠️
...c/components/paid-ads/ads-campaign/ads-campaign.js 0.0% 2 Missing ⚠️
...c/components/stepper/step-content-actions/index.js 33.3% 1 Missing and 1 partial ⚠️
js/src/components/tree-select-control/control.js 0.0% 1 Missing and 1 partial ⚠️
js/src/data/actions.js 50.0% 2 Missing ⚠️
... and 10 more
Additional details and impacted files

Impacted file tree graph

@@                               Coverage Diff                                @@
##           update/2535-consolidate-ad-creation-ccf-merged   #2627     +/-   ##
================================================================================
- Coverage                                            62.1%   61.0%   -1.1%     
================================================================================
  Files                                                 337     330      -7     
  Lines                                                5209    5183     -26     
  Branches                                             1253    1254      +1     
================================================================================
- Hits                                                 3236    3162     -74     
- Misses                                               1790    1832     +42     
- Partials                                              183     189      +6
Files with missing lines Coverage Δ
js/src/attribute-mapping/index.js 100.0% <ø> (ø)
...ion/phone-number-card/verification-code-control.js 98.2% <100.0%> (-0.1%) ⬇️
...choose-audience-section/choose-audience-section.js 33.3% <ø> (+8.3%) ⬆️
...listings/configure-product-listings/checkErrors.js 100.0% <100.0%> (ø)
js/src/components/main-tab-nav/main-tab-nav.js 90.0% <100.0%> (ø)
...src/components/paid-ads/ads-campaign/faqs-panel.js 66.7% <100.0%> (ø)
...components/paid-ads/asset-group/images-selector.js 100.0% <ø> (ø)
...rc/components/stepper/step-content-footer/index.js 50.0% <100.0%> (+16.7%) ⬆️
js/src/components/tree-select-control/tags.js 92.9% <100.0%> (ø)
js/src/components/vertical-gap-layout/index.js 100.0% <ø> (ø)
... and 41 more

... and 14 files with indirect coverage changes

View more details on Codecov