Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.8.4 #2569

Merged
merged 78 commits into from
Aug 27, 2024
Merged

Release 2.8.4 #2569

merged 78 commits into from
Aug 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 27, 2024

Checklist

  1. Check if the version, base, and target branches are as you desire.
  2. Make sure you have woorelease installed and set up.
  3. Go to your local repo clone, and check out this PR to be able to commit any potential adjustments.
    git fetch origin release/2.8.4
    git checkout release/2.8.4
  4. Remove older changelog entries from readme.txt (keep the last two versions, since we will be adding a third during the release), commit changes.
  5. If there are new database migration classes (under src/DB/Migration/), modify their applicable version set in the get_applicable_version class of each migration class to be the same value as the version that is to be released.
    ⚠️ Notice that x.x.x is not a valid version and should be set manually with the new version. So, for example, if we are releasing version 1.12.0 and there is a file Migration20211228T1640692399.php inside src/DB/Migration/, you should open that file and in the method get_applicable_version return 1.12.0.
  6. ❗ If this release has updated composer packages, we should test Composer package conflicts with other plugins.
  7. Simulate the release locally
    woorelease simulate --product_version=2.8.4  --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.8.4
    Note: Select y when prompted: "Would you like to add/delete them in the svn working copy?"
  8. The changelog is correct.
    Check if some entries are missing, need rewording, or need to be deleted. You can edit respective PRs by changing their title, ### Changelog entry section, or assigning the changelog: none label.
    You can also edit the changelog manually in the woorelease release step later.
  9. Automated tests are passing.
  10. Test the package
    1. Install the /tmp/google-listings-and-ads.zip file on a test site
    2. Confirm it activates without warnings/errors and is showing the right versions
    3. Run a few basic smoke tests

Next steps

  1. Do the final release
    woorelease release --product_version=2.8.4   --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.8.4
    
    When prompted for changelog entries, double-check and apply any changes if needed.
  2. Confirm the release using the activation link from your email.
    When releasing to WordPress.org, “release notifications” have been enabled, so each committer will be sent an email with an action link to confirm the release. This must be done after committing in SVN before the release becomes available. See the following page for releases pending notifications: https://wordpress.org/plugins/developers/releases/
  3. Go to https://github.com/woocommerce/google-listings-and-ads/releases/2.8.4, generate GitHub release notes, and paste them as a comment here.
  4. Merge this PR after the new release is successfully created and the version tags are updated.
  5. Merge trunk to develop (PR), if applicable for this repo.
  6. Update documentation
    • Publish any new required docs
    • Update triggers/rules/actions listing pages
  7. Mark related ideas complete on the feature requests page.

jorgemd24 and others added 30 commits August 14, 2024 20:57
Fixed by running `npm run lint:js -- --fix`.
Migration includes:
- Invoke `userEvent.setup()` in the test itself and before the component is rendered.
- Adding `async` and `await` as all APIs are asynchronous.
- No need to be wrapped in `act`.
- Replace the simulation of pressing buttons with the `keyboard` API.
- `clear()` is changed to only support editable elements only.
puntope and others added 21 commits August 23, 2024 11:31
Use a fixed SKU number when testing product adapter
Upgrade to use Node.js 20 and bump npm dependencies
…20-and-compatible-wp-wc

Migrate jest tests to use Node.js 20 and make components compatible with upgraded packages
Upgrade to use Node.js 20 and make components compatible with upgraded packages
Update 'Linked accounts' to include Google Ads
…st-with-comma-separator

Fix issue with comma separators for Shipping Rates
Return settings prop as object in the REST API
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 77.86885% with 27 lines in your changes missing coverage. Please review.

Project coverage is 64.5%. Comparing base (d2c2acc) to head (b5aee0c).

Files Patch % Lines
js/src/components/app-tooltip/index.js 50.0% 3 Missing and 1 partial ⚠️
js/src/components/tree-select-control/index.js 78.6% 3 Missing ⚠️
...ute-mapping/attribute-mapping-delete-rule-modal.js 0.0% 1 Missing and 1 partial ⚠️
.../attribute-mapping/attribute-mapping-rule-modal.js 50.0% 1 Missing and 1 partial ⚠️
js/src/components/tree-select-control/control.js 0.0% 1 Missing and 1 partial ⚠️
js/src/data/actions.js 50.0% 2 Missing ⚠️
...roduct-feed/review-request/review-request-modal.js 50.0% 2 Missing ⚠️
src/ConnectionTest.php 0.0% 2 Missing ⚠️
js/src/components/paid-ads/campaign-assets-form.js 66.7% 1 Missing ⚠️
js/src/components/tree-select-control/checkbox.js 50.0% 1 Missing ⚠️
... and 6 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #2569      +/-   ##
==========================================
+ Coverage     63.8%   64.5%    +0.7%     
- Complexity       0    4591    +4591     
==========================================
  Files          326     796     +470     
  Lines         5089   22992   +17903     
  Branches      1232    1234       +2     
==========================================
+ Hits          3247   14837   +11590     
- Misses        1674    7982    +6308     
- Partials       168     173       +5     
Flag Coverage Δ
js-unit-tests 62.8% <76.9%> (-1.1%) ⬇️
php-unit-tests 65.0% <83.3%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ion/phone-number-card/verification-code-control.js 98.2% <100.0%> (-0.1%) ⬇️
...ponents/free-listings/setup-free-listings/index.js 6.8% <ø> (ø)
...components/paid-ads/asset-group/images-selector.js 100.0% <ø> (ø)
js/src/components/tree-select-control/tags.js 92.9% <100.0%> (ø)
...e-card/program-toggle/pause-program-modal/index.js 14.3% <ø> (ø)
...emove-program-button/remove-program-modal/index.js 7.1% <ø> (ø)
js/src/gtag-events/utils.js 96.2% <100.0%> (ø)
js/src/hooks/useMCIssuesTotals.js 100.0% <100.0%> (ø)
js/src/product-feed/issues-table-card/index.js 100.0% <100.0%> (ø)
.../product-feed-table-card/edit-visibility-action.js 52.9% <ø> (ø)
... and 23 more

... and 486 files with indirect coverage changes

@tomalec
Copy link
Member

tomalec commented Aug 27, 2024

🧪 E2E tests are passing

🧪 QIT tests passing

  • activation
  • api
  • security

@tomalec
Copy link
Member

tomalec commented Aug 27, 2024

  • Dev - Align namespaces for unit tests.
  • Dev - Avoid accidentally using the event object to reset the asset group values in the CampaignAssetsForm component.
  • Dev - Migrate jest tests to use Node.js 20.
  • Dev - Rewrite the replacer of JSON.stringify in getReportKey to ensure it returns the same key regardless of the query keys' order.
  • Dev - Upgrade to use Node.js 20 and bump npm dependencies.
  • Dev - Use a fixed SKU number when testing product adapter.
  • Fix - issue with comma separators for Shipping Rates.
  • Tweak - Connect Test Page errors when WPCOM token is not connected.
  • Tweak - Make the Tooltip use the new placement prop when WordPress >= 6.4.
  • Tweak - Replace deprecated event.keyCode with event.code for the verification code inputs in the contact information setting.
  • Tweak - Update the copy in the "Linked accounts" of the accounts connection setting to include Google Ads account.

What's Changed

[Fix] Fixes 🛠

[Tweak] Tweaked 🔧

[Dev] Developer-facing changes 🧑‍💻

Full Changelog: 2.8.3...2.8.4

@tomalec tomalec merged commit aeb4245 into trunk Aug 27, 2024
@tomalec tomalec deleted the release/2.8.4 branch August 27, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants