Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the language setting during onboarding #2522

Conversation

dsawardekar
Copy link
Collaborator

@dsawardekar dsawardekar commented Aug 14, 2024

Changes proposed in this Pull Request:

Closes #2489 .

This PR hides the language settings UI during the onboarding steps.

Screenshots:

Screenshot from 2024-08-13 11-36-30

Detailed test instructions:

  1. On a fresh setup, go through the onboarding process.
  2. On the second page of onboarding, you should no longer see the Language Selection radio button.

Additional details:

Update - Hides the language setting during onboarding

Changelog entry

Update - Hides the language setting during onboarding.

@github-actions github-actions bot added the changelog: update Big changes to something that wasn't broken. label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.8%. Comparing base (f398161) to head (766e351).
Report is 157 commits behind head on feature/2458-streamline-onboarding.

Additional details and impacted files

Impacted file tree graph

@@                           Coverage Diff                           @@
##             feature/2458-streamline-onboarding   #2522      +/-   ##
=======================================================================
- Coverage                                  64.5%   63.8%    -0.7%     
=======================================================================
  Files                                       795     326     -469     
  Lines                                     22844    5088   -17756     
  Branches                                   1220    1232      +12     
=======================================================================
- Hits                                      14739    3247   -11492     
+ Misses                                     7938    1673    -6265     
- Partials                                    167     168       +1     
Flag Coverage Δ
js-unit-tests 63.8% <ø> (+0.3%) ⬆️
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...choose-audience-section/choose-audience-section.js 33.3% <ø> (+8.3%) ⬆️

... and 480 files with indirect coverage changes

@dsawardekar dsawardekar marked this pull request as ready for review August 14, 2024 05:35
@dsawardekar dsawardekar self-assigned this Aug 14, 2024
@joemcgill joemcgill self-requested a review August 15, 2024 14:45
Copy link
Collaborator

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct and I confirmed that the language field is now hidden on both the onboarding form and the Edit Free Listings screen after onboarding (/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fdashboard&subpath=%2Ffree-listings%2Fedit).

E2E tests are passing locally for me.

@ankitguptaindia
Copy link
Member

QA/Test Report-

Testing Environment -

  • WordPress: 6.6.1
  • Theme: Storefront Version: 4.6.0 / Twenty Twenty-Four Version: 1.2
  • WooCommerce - Version 9.1.4
  • PHP: 8.3
  • Web Server: Nginx
  • Browser: Chrome - Version 127
  • OS: macOS Sonoma 14.5
  • Git Branch:

Test Results - Changes working as expected. Onboarding flow works fine after new changes.

Functional Demo / Screencast -

image

Next Step- Ready to Code Review(Woo)

Plugin file with this fix-specific branch: google-listings-and-ads.zip

cc: @joemcgill for progress update.

@eason9487 eason9487 changed the title Update/2489 hide language setting onboarding Hide the language setting during onboarding Aug 20, 2024
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work and the change looks good.

Left a few suggestions about code no longer in use. It would be great if they could be removed as well.

Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@eason9487
Copy link
Member

Pushed 766e351 to update the tracking README file.

@joemcgill joemcgill changed the base branch from develop to feature/2458-streamline-onboarding August 22, 2024 13:58
@joemcgill joemcgill merged commit bfe429d into feature/2458-streamline-onboarding Aug 22, 2024
7 checks passed
@joemcgill joemcgill deleted the update/2489-hide-language-setting-onboarding branch August 22, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: update Big changes to something that wasn't broken.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboarding: Remove Language Setting UI
4 participants