-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(R2.1f) Google tag enhanced conversion #2258
Merged
joemcgill
merged 23 commits into
feature/2239-enhanced-conversions-panel
from
update/52310672-google-tag-enhanced-conversion
Mar 21, 2024
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
672800e
Update src/Google/GlobalSiteTag.php
ankitrox e3cf005
E2E: Enhanced conversion user data test
ankitrox 7523ea1
Merge branch 'update/52310672-google-tag-enhanced-conversion' of http…
ankitrox 93f9c4b
Conflict resolve: develop
ankitrox 9ccbba8
Resolve conflict: merge feature/2239-enhanced-conversions-panel
ankitrox 62fb97e
Merge branch 'feature/2239-enhanced-conversions-panel' into update/52…
ankitrox 85e005a
Conditionally add enhanced conversion event
ankitrox b43997b
Normalize and hash data
ankitrox a4e289a
Merge branch 'feature/2239-enhanced-conversions-panel' into update/52…
ankitrox 365139c
Fix: algo name
ankitrox 1c57792
Fix: key name for hashed data
ankitrox ea8cd23
Resolve conflicts: merge develop
ankitrox e93b854
Add EC data prior to firing events
joemcgill c0da595
Update e2e tests
joemcgill 1afe1d5
Remove E2E tests for now
joemcgill ce4441e
Add e2e tests
joemcgill 84343ae
Fix JSDoc errors
joemcgill 8ee59b6
Fix tests
joemcgill 72a2f2a
Enable EC for e2e test
joemcgill aaa28be
Make disabled test more robust
joemcgill 7d60a3f
Add normalization for email address
ankitrox 447f12a
Resolve conflicts during pull
ankitrox c2d73c2
Remove hashing from non PII fields and fix merge
joemcgill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working, as in it's adding the snippet to the page:
But when I look at the tracking data sent to Google I'm not seeing the valid data being sent. I'm following the instructions: Validate your implementation using Chrome Developer Tools
I can see the regular data about the event:
But this part I'm not seeing:
How can I confirm it is actually including the data? It seems the E2E tests are also just checking for the user_data being sent in the page, and not for the data being sent in the tracking request. That would make it closer to a unit test if it confirms the data is output in the page, seeing expected data appear in the tracking request like is done for the other tests would be more of an E2E test.
The other way to validate the data is to check the Ads account, but it says I have to wait 48hours for that, so I'll have to get back to you if it ever appears.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I can't see the
em
property as mentioned in the document, but I think if its possible we should wait to check if it is being reflected in ads account after 48 hours as we did all the steps according to the documentation.