Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free Listings + Paid Ads: Add event tracking #1689

Merged

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Sep 22, 2022

Changes proposed in this Pull Request:

This PR implements the 📌 Event tracking in #1610.

  • Add event trackings for the buttons in the last step of onboarding flow

Detailed test instructions:

  1. Enable event tracking logging by running localStorage.setItem( 'debug', 'wc-admin:*' ) in the Console tab of DevTool, and refresh page to make it effective.
  2. Go to step 4 of onboarding flow.
  3. Test the four buttons that are marked as A, B, C, D in the screenshots of Event tracking.
  4. Check if the event names and their properties are the same as the requirements.

Changelog entry

@eason9487 eason9487 added the changelog: none Skip changelog entry for this PR label Sep 22, 2022
@eason9487 eason9487 requested a review from a team September 22, 2022 05:32
@eason9487 eason9487 self-assigned this Sep 22, 2022
@github-actions github-actions bot added changelog: add A new feature, function, or functionality was added. type: enhancement The issue is a request for an enhancement. labels Sep 22, 2022
@eason9487 eason9487 removed type: enhancement The issue is a request for an enhancement. changelog: add A new feature, function, or functionality was added. labels Sep 22, 2022
@puntope
Copy link
Contributor

puntope commented Sep 22, 2022

❓ Tracking in C and D worked for me. However after I created the Ads setup... I was not able to see again the A, B buttons (even I deleted all %gla% options as well as disconnected accounts.

@puntope
Copy link
Contributor

puntope commented Sep 22, 2022

⚠️ Another issue I found here thats seems to be unrelated with this PR... is about Phone number.

Steps:

  • Verify the phone number
  • Click continue and go to last step
  • Click back in the top navigation
  • Phone number cards shows still and editable and continue button disabled
Screen.Recording.2022-09-22.at.11.03.08.mov

@eason9487
Copy link
Member Author

@puntope, thank you for the code review.

❓ Tracking in C and D worked for me. However after I created the Ads setup... I was not able to see again the A, B buttons (even I deleted all %gla% options as well as disconnected accounts.

Once a merchant continues with the paid ads settings, the showPaidAdsSetup state will be stored in sessionStorage. I thought merchants almost won't do these things with the same browser tab: Complete the onboarding, disconnect all accounts, and then restart onboarding again. Even though this use case happens, it won't make the onboarding flow unworkable, thus I didn't clear the state from sessionStorage.

⚠️ Another issue I found here thats seems to be unrelated with this PR... is about Phone number. [...]

I believe it relates to #1033, and that missing implementation became looks like a bug after adding a new step behind the content info step.

Copy link
Contributor

@puntope puntope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Tested locally and my questions were clarified

✅ Clicking on Setup Ads and then in Skip without configure/connect the Ads

Screenshot 2022-09-22 at 10 56 27

Screenshot 2022-09-22 at 10 56 24

✅ Clicking on Setup Ads and then in Skip after connecting the Ads Account

Screenshot 2022-09-22 at 11 08 50

✅ Click on Skip

Screenshot 2022-09-22 at 12 56 00

✅ Complete the Ads Setup and Click on Complete

Screenshot 2022-09-22 at 13 33 37

Base automatically changed from update/1610-store-restore-paid-ads-states to feature/1610-streamlined-onboarding September 26, 2022 04:28
@eason9487 eason9487 merged commit 12a261b into feature/1610-streamlined-onboarding Sep 26, 2022
@eason9487 eason9487 deleted the add/1610-event-tracking branch September 26, 2022 04:29
@eason9487 eason9487 added changelog: add A new feature, function, or functionality was added. and removed changelog: none Skip changelog entry for this PR labels Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: add A new feature, function, or functionality was added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants