Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free Listings + Paid Ads: Update learn more links, FAQs, CSS disclaimer, submission success modal, and title of free listings settings #1679

Merged
merged 9 commits into from
Sep 21, 2022

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Sep 16, 2022

Changes proposed in this Pull Request:

This PR implements the rest parts of 📌 Update other UI changes in #1610.

  • Change the URLs of the learn more links to the formal ones in the ads setup of onboarding flow.
  • Update the FAQs in the ads setup.
  • Add the disclaimer of Comparison Shopping Service to the accounts setup of onboarding flow.
  • Implement the submission success modal on the product feed page after the onboarding is completed along with paid ads.
  • Set different titles for the free listings setup of the onboarding and editing pages.

Screenshots:

📷 Disclaimer of Comparison Shopping Service

image

image

📷 FAQs in the ads setup

image

📷 Submission success modal when the onboarding is completed along with paid ads

image

📷 Different title on the edit free listings page

image

Detailed test instructions:

  1. Go to the first step of onboarding flow.
  2. Check if the copywriting of CSS disclaimer is the same as it is on Figma and if the UI is similar to the visual design.
  3. Go to the last step of onboarding flow.
  4. Click on the two "Learn more" links on the left side to see if the formal pages are opened.
  5. View the FAQs to check if the copywriting is the same as it is on Figma.
  6. Complete the onboarding flow with sklp ads setup. (This revision doesn't include the implementation of completing with ads setup)
  7. Go to the Product Feed page with the opening submission success modal: /wp-admin/admin.php?page=wc-admin&guide=submission-success&path=%2Fgoogle%2Fproduct-feed.
    • Without setting up ads, the content on the modal should have two pages.
    • Locally change the adsSetupComplete value to true and refresh page to simulate the finished ads setup. Check if the modal has the same copywriting as it is on Figma.

Changelog entry

Add - The disclaimer of Comparison Shopping Service of the accounts setup of onboarding flow.
Add - The submission success modal on the Product Feed page after the onboarding is completed along with paid ads setup.
Update - The FAQs in the paid ads setup and the campaign setup page.
Tweak - Use different titles for the free listings setup of the onboarding and editing pages.

@eason9487 eason9487 requested a review from a team September 16, 2022 11:40
@eason9487 eason9487 self-assigned this Sep 16, 2022
@github-actions github-actions bot added the changelog: update Big changes to something that wasn't broken. label Sep 16, 2022
@puntope
Copy link
Contributor

puntope commented Sep 20, 2022

💅 In Figma the CSS Disclaimer texts is 11px and in implementation it's 12px

@puntope
Copy link
Contributor

puntope commented Sep 20, 2022

💅 In disclaimer CSS --- I can still click on the elements (for example the links of the disclaimer) when it's disabled

@@ -19,19 +19,14 @@ import GuidePageContent, {
ContentLink,
} from '.~/components/guide-page-content';
import AddPaidCampaignButton from '.~/components/paid-ads/add-paid-campaign-button';
import { GUIDE_NAMES, LOCAL_STORAGE_KEYS } from '.~/constants';
import { glaData, GUIDE_NAMES, LOCAL_STORAGE_KEYS } from '.~/constants';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅 This glaData could be in UPPERCASE because it's a constant. I'm not sure if this is coming from the past.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glaData references to window.glaData, and its declaration and its lower-case properties are created by PHP side. In addition, it's more like preloading data rather than a collection of constants. Considering this seems to be out of the scope of this PR/project, I'm not leaning towards adjusting it in this PR.

Copy link
Contributor

@puntope puntope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

💅 Check if the copywriting and UI of CSS disclaimer --> Left some minor comments. Not really a blocker
✅ two "Learn more" links on the left side.
✅ Checked the FAQs
✅ Checked the Guide Modal with and without Ads Completed

💅 Would be cool to add a test at least for the Success Guide Modal behaviour with and without Ads Completed. But could be done in future PRs

@eason9487
Copy link
Member Author

Thanks for the code review, @puntope

In Figma the CSS Disclaimer texts is 11px and in implementation it's 12px

Browsers may have a limitation to force the font size smaller than n to a minimum size when rendering, for example, Chrome uses 12px as the minimum size, so I didn't style it with 11px. Although the ScaledText component can still work around the limitation, I assumed the workaround only be used within the ad preview scope.

In disclaimer CSS --- I can still click on the elements (for example the links of the disclaimer) when it's disabled

I think it should be ok that those links are clickable in CSS disclaimer when it's rendered in disabled style. The prop names disabled and disabledLeft might bring confusion. We could create a follow-up to rename all uses to a proper one.

@eason9487 eason9487 merged commit 694d25d into feature/1610-streamlined-onboarding Sep 21, 2022
@eason9487 eason9487 deleted the update/1610-ui-updates branch September 21, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: update Big changes to something that wasn't broken.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants