Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Free Listings + Paid Ads: Add the ads audience and budget sections #1655

Merged
merged 7 commits into from
Sep 5, 2022
Merged

Free Listings + Paid Ads: Add the ads audience and budget sections #1655

merged 7 commits into from
Sep 5, 2022

Commits on Aug 26, 2022

  1. Tweak UI for the AudienceSection component

    @eason9487
    eason9487 committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    6518b79 View commit details
    Browse the repository at this point in the history

  2. Tweak UI for the BudgetSection-related components

    @eason9487
    eason9487 committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    0947ec3 View commit details
    Browse the repository at this point in the history

  3. Fix that the validation of campaign amount should only allow a numb… 

    …er type (excluding NaN)
    @eason9487
    eason9487 committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    e38a58a View commit details
    Browse the repository at this point in the history

  4. Add the ads audience and budget sections to step 4 of the onboarding … 

    …flow for paid campaign creation
    @eason9487
    eason9487 committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    3e0debd View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Use constants for the action values in the SetupPaidAds component. 

    Address #1649 (comment)
    @eason9487
    eason9487 committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    0e65308 View commit details
    Browse the repository at this point in the history

  2. Two values were missed to be replaced with constants in the previous … 

    …commit.

Ref: 3e0debd
    @eason9487
    eason9487 committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    c08364f View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Use constants for the status of Google Ads account. 

    Address #1655 (comment)
    @eason9487
    eason9487 committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4d7da2b View commit details
    Browse the repository at this point in the history