-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Plugin Icons #1653
Update Plugin Icons #1653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon changes look good to me. Just wanted to mention that they need to be manually committed to svn, as that's not something WR will handle, nor are they tied to a specific version.
So you'll need to commit them to this folder: https://plugins.svn.wordpress.org/google-listings-and-ads/assets/
See details here: https://developer.wordpress.org/plugins/wordpress-org/plugin-assets/
How can I commit that manually ? Is there a command? In the docs you send me I dont see it |
I found this... probably is what Im lokking for... I will investigate further tomorrow https://svnbook.red-bean.com/en/1.8/svn.ref.svn.c.commit.html |
Yes you'll need to use some basic svn commands to checkout a copy and commit the changes (similar to how you would use git from the command line). Here is an example of how I've done it in the past:
You can run |
Interesting, thanks @mikkamp I will try it and add some docs to the wiki for the future
Can you elaborate how can I add here the files? |
Never mind, I see it was just replace the files in the directory |
Changes proposed in this Pull Request:
Closes #1644
Replace old google Shopping icons with the new ones with the G letter logo
Screenshots
Detailed test instructions:
wordpress_org_assets
Changelog entry