Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Plugin Icons #1653

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Update Plugin Icons #1653

merged 1 commit into from
Aug 26, 2022

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Aug 25, 2022

Changes proposed in this Pull Request:

Closes #1644

Replace old google Shopping icons with the new ones with the G letter logo

Screenshots

Screenshot 2022-08-25 at 18 27 59

Screenshot 2022-08-25 at 18 28 04

Detailed test instructions:

  • Check the new images in wordpress_org_assets
  • Check the image icon.svg - 128x128 and with white background
  • Check the image icon-no-bg.svg - 128x128 and with NO background
  • Check the image icon128x128.png - 128x128 and with white background
  • Check the image icon256x256.png - 256x256 and with white background
  • Check that there is no icons in the code referring to the old icons

Changelog entry

Tweak - Updated plugin icons

@puntope puntope added the changelog: tweak Small change, that isn't actually very important. label Aug 25, 2022
@puntope puntope requested a review from a team August 25, 2022 14:28
@puntope puntope self-assigned this Aug 25, 2022
Copy link
Contributor

@mikkamp mikkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon changes look good to me. Just wanted to mention that they need to be manually committed to svn, as that's not something WR will handle, nor are they tied to a specific version.

So you'll need to commit them to this folder: https://plugins.svn.wordpress.org/google-listings-and-ads/assets/

See details here: https://developer.wordpress.org/plugins/wordpress-org/plugin-assets/

@puntope
Copy link
Contributor Author

puntope commented Aug 25, 2022

So you'll need to commit them to this folder: https://plugins.svn.wordpress.org/google-listings-and-ads/assets/

How can I commit that manually ? Is there a command?

In the docs you send me I dont see it

@puntope
Copy link
Contributor Author

puntope commented Aug 25, 2022

I found this... probably is what Im lokking for... I will investigate further tomorrow

https://svnbook.red-bean.com/en/1.8/svn.ref.svn.c.commit.html

@mikkamp
Copy link
Contributor

mikkamp commented Aug 25, 2022

Yes you'll need to use some basic svn commands to checkout a copy and commit the changes (similar to how you would use git from the command line).

Here is an example of how I've done it in the past:

mkdir svn && cd svn
svn checkout https://plugins.svn.wordpress.org/google-listings-and-ads --depth immediates
cd google-listings-and-ads/assets && svn update --set-depth infinity .
-- Replace with new files here --
svn ci -m 'Updating assets'

You can run svn status to see what actually changed before running the commit (ci) command.

@puntope
Copy link
Contributor Author

puntope commented Aug 26, 2022

Interesting, thanks @mikkamp I will try it and add some docs to the wiki for the future

-- Replace with new files here --

Can you elaborate how can I add here the files?

@puntope
Copy link
Contributor Author

puntope commented Aug 26, 2022

Never mind, I see it was just replace the files in the directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Google-related logos to the generic G logo
2 participants