Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Free Listings + Paid Ads: Add the paid ads previews to the boost product listings section #1650

Merged
merged 17 commits into from
Aug 30, 2022
Merged

Free Listings + Paid Ads: Add the paid ads previews to the boost product listings section #1650

merged 17 commits into from
Aug 30, 2022

Commits on Aug 24, 2022

  1. Add new images for the mockups of ad previews

    @eason9487
    eason9487 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    8735780 View commit details
    Browse the repository at this point in the history

  2. Add the container for ad previews

    @eason9487
    eason9487 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    1bde4a9 View commit details
    Browse the repository at this point in the history

  3. Implement shared components for the mockups of ad previews

    @eason9487
    eason9487 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    7e1d5a5 View commit details
    Browse the repository at this point in the history

  4. Implement the Google Shopping mockup of ad previews

    @eason9487
    eason9487 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    ca99756 View commit details
    Browse the repository at this point in the history

  5. Implement the YouTube mockup of ad previews

    @eason9487
    eason9487 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    88cfb40 View commit details
    Browse the repository at this point in the history

  6. Implement the Google Search mockup of ad previews

    @eason9487
    eason9487 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    87ce3bc View commit details
    Browse the repository at this point in the history

  7. Implement the Google Map mockup of ad previews

    @eason9487
    eason9487 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    ced245d View commit details
    Browse the repository at this point in the history

  8. Implement the Google Display Network mockup of ad previews

    @eason9487
    eason9487 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    1aa32c6 View commit details
    Browse the repository at this point in the history

  9. Implement the Gmail mockup of ad previews

    @eason9487
    eason9487 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    3b73e32 View commit details
    Browse the repository at this point in the history

  10. Move useCountdown.js to hooks directory and change the handle param… 

    …eter to be optional
    @eason9487
    eason9487 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    f3cc043 View commit details
    Browse the repository at this point in the history

  11. Add ad previews to the paid ads features section

    @eason9487
    eason9487 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    05779b9 View commit details
    Browse the repository at this point in the history

  12. Rebalance the bundlewatch's max size of index.css to 120% of the new … 

    …size since there is an unavoidable increase in this PR
    @eason9487
    eason9487 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    3279a21 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Update the sample product image file to remove the white border from … 

    …the image
    @eason9487
    eason9487 committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    6fe6ba7 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Fix a typo in the JSDoc of js/src/components/paid-ads/campaign-previe… 

    …w/index.js

Address #1650 (comment)
    @eason9487
    eason9487 committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    8e72981 View commit details
    Browse the repository at this point in the history

  2. Fix the broken layout of PaidAdsFeaturesSection for the smaller viewp… 

    …orts.

Address #1650 (comment)
    @eason9487
    eason9487 committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    656aeb9 View commit details
    Browse the repository at this point in the history

  3. Merge thinnest, thinner, and thicker props as a single stroke prop fo… 

    …r Placeholder and adjust some values of them to align with visual design.

Address #1650 (comment)
    @eason9487
    eason9487 committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    c6908de View commit details
    Browse the repository at this point in the history

  4. Merge smaller and larger props as a single size prop for ScaledText. 

    Address #1650 (comment)
    @eason9487
    eason9487 committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    631e8fe View commit details
    Browse the repository at this point in the history