Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly parses the facing configuration option #256

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

demedos
Copy link
Contributor

@demedos demedos commented Mar 16, 2023

Currently, when the configuration is disableFaceUpDown: false, the facing is incorrectly disabled.
This is due to the fact that natively the check is done simply by checking the existence of the key in the dictionary like so:

_disableFaceUpDown = [options objectForKey:@"disableFaceUpDown"] != nil;

This change will correctly parse the boolean option

NSNumber *disableFaceUpDown = [options objectForKey:@"disableFaceUpDown"];
_disableFaceUpDown = [disableFaceUpDown boolValue];

@wonday wonday merged commit f483520 into wonday:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants