Fix binary locations for temporal package and it's sub packages #8897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mritunjaysharma394
left a comment
mritunjaysharma394
left a comment
There was a problem hiding this comment.
We will also need epoch bump for both since we are making changes them
mritunjaysharma394
requested changes
Nov 21, 2023
rawlingsj
reviewed
Nov 21, 2023
Contributor
Author
|
I resolved all the comments and fixed CVE; @rawlingsj, shall we merge this now? |
Contributor
Author
|
blocked on wolfi-dev/advisories#572 |
rawlingsj
requested changes
Nov 28, 2023
Member
|
Thanks - it's close, just a cpl of small suggested changes |
Contributor
Author
|
wolfi-dev/advisories#572 is merged |
Signed-off-by: Shivanshu Raj Shrivastava <shivanshu1333@gmail.com>
Signed-off-by: Shivanshu Raj Shrivastava <shivanshu1333@gmail.com>
Signed-off-by: Shivanshu Raj Shrivastava <shivanshu1333@gmail.com>
rawlingsj
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix binary locations for the temporal package and it's sub-packages