-
Notifications
You must be signed in to change notification settings - Fork 416
add rancher-machine #48624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rancher-machine #48624
Conversation
Signed-off-by: Dentrax <[email protected]>
kranurag7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good, I'm thinking if we should use 0.15.0.126 version so that we avoid if any possible regressions on main. (I understand that the chances of this happening is low given they only bump dependencies but this is a non-blocker in getting this merged)
I hope that tests are enough to catch the possible regressions if they come up on master branch.
|
Yeah but I'm not sure on this. Pinning version would require passing version-prefix filter and resulting version stream, we would also miss the 0.15.1 if they will cut it in the future. |
|
@Dentrax I don't believe there will ever be a 0.15.1, but there will continue to be |
Signed-off-by: Dentrax <[email protected]>
|
Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation. To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify: e.g. /ai-verify partially helpful but I also added bash to the build environment Gen AI suggestions to solve the build error: • Detected Error: "FAIL Expected commit 99d2c8daa21d3e81eebb3cfcda46459473628126 for v0.15.0-rancher126, found 9d46e6bb16f98d184afa83267ea28d3dcc898478" • Error Category: Version/Git Commit Verification • Failure Point: git-checkout pipeline step verification of expected commit hash • Root Cause Analysis: The expected commit hash in the melange YAML doesn't match the actual commit hash for the specified tag v0.15.0-rancher126 • Suggested Fix:
- uses: git-checkout
with:
repository: https://github.com/rancher/machine
expected-commit: 9d46e6bb16f98d184afa83267ea28d3dcc898478
tag: v${{vars.mangled}}• Explanation: The build system is correctly verifying git commit hashes to ensure reproducible builds and security. The current expected-commit hash (99d2c8...) doesn't match the actual commit hash (9d46e6...) for the tag v0.15.0-rancher126. Updating to the correct hash will allow the verification to pass. • Additional Notes:
• References: |
Signed-off-by: Dentrax <[email protected]> Co-authored-by: James Rawlings <[email protected]> Signed-off-by: Dentrax <[email protected]>
Needed by Rancher package.
CVEs in moby/moby can't be properly mitigated, as upgrading to different versions results in compilation failures.
Example:
Fixes:
Related:
Pre-review Checklist
For new package PRs only
endoflife.date)For new version streams
name: ${{package.name}}-compat)provides:logical unversioned forms of the package (e.g.nodejs,nodejs-lts)For package updates (renames) in the base images
When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)
apk upgrade --latestsuccessfully upgrades packages or performs no actionsFor security-related PRs
For version bump PRs
epochfield is reset to 0For PRs that add patches