Skip to content

Conversation

@octo-sts
Copy link
Contributor

@octo-sts octo-sts bot commented Mar 21, 2025

No description provided.

@octo-sts
Copy link
Contributor Author

octo-sts bot commented Mar 21, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

• Detected Error: "warning: refs/tags/v17.10.0 37fd1eef84d344e9adeae00f228c7185f4187be2 is not a commit!"

• Error Category: Version/Git Tag

• Failure Point: Git checkout step during the build process

• Root Cause Analysis: The tag v17.10.0 appears to be pointing to a non-commit object (likely a tag object instead of a commit object), and the specified expected-commit hash doesn't match

• Suggested Fix:

  1. Update the git-checkout step to fetch the full tag object:
  - uses: git-checkout
    with:
      repository: https://gitlab.com/gitlab-org/gitaly.git
      tag: v${{package.version}}
      expected-commit: 37fd1eef84d344e9adeae00f228c7185f4187be2  # Update this
      depth: 2  # Add this line
  1. Alternatively, verify and update the correct commit hash by running:
git ls-remote https://gitlab.com/gitlab-org/gitaly.git refs/tags/v17.10.0^{}

• Explanation: The error occurs because GitLab often uses annotated tags, which are tag objects pointing to commits. The current checkout strategy is trying to treat the tag as a direct commit reference. By either fetching with greater depth or using the correct dereferenced commit hash, we can properly resolve the tag to its commit.

• Additional Notes:

  • Annotated tags (which GitLab uses) require an additional dereference step
  • The current expected-commit hash seems to be incorrect for this version
  • Adding depth: 2 allows proper resolution of annotated tags
  • This is a common issue when dealing with GitLab repository tags

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Mar 21, 2025
@AmberArcadia AmberArcadia self-assigned this Mar 21, 2025
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Mar 21, 2025
@AmberArcadia AmberArcadia requested a review from a team March 21, 2025 17:45
@OddBloke OddBloke merged commit bbf37ce into main Mar 21, 2025
20 of 21 checks passed
@OddBloke OddBloke deleted the gitaly-17.10 branch March 21, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. service:version-stream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants