Chase melange ${{targets.contextdir}} changes #4619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some packages used `mv` to move files into the subpkgdir after building
them. Now that we have ${{targets.contextdir}}, this extra `mv` step
is no longer needed: the go/build pipeline now follows the context dir
instead.
Signed-off-by: Ariadne Conill <[email protected]>
Contributor
Package bank-vaults: Click to expand/collapsePackage bank-vaults: Package gitlab-runner: Click to expand/collapsePackage gitlab-runner: Package guac: Click to expand/collapsePackage guac: Package guaccsub: Click to expand/collapsePackage guaccsub: Package bank-vaults-template: Click to expand/collapsePackage bank-vaults-template: Package gitlab-runner-helper: Click to expand/collapsePackage gitlab-runner-helper: Package guacingest: Click to expand/collapsePackage guacingest: Package guacone: Click to expand/collapsePackage guacone: Package guacgql: Click to expand/collapsePackage guacgql: |
Contributor
Author
|
These CI results are to be expected, as they depend on the new Melange changes |
rawlingsj
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages used
mvto move files into the subpkgdir after building them. Now that we have ${{targets.contextdir}}, this extramvstep is no longer needed: the go/build pipeline now follows the context dir instead.