-
Notifications
You must be signed in to change notification settings - Fork 416
feat(chromium): Add support for arm64 #44107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: RJ Sampson <[email protected]>
Inheritance does not work in the package environment Also do some cleanup Signed-off-by: RJ Sampson <[email protected]>
Signed-off-by: RJ Sampson <[email protected]>
Signed-off-by: RJ Sampson <[email protected]>
Signed-off-by: RJ Sampson <[email protected]>
Signed-off-by: RJ Sampson <[email protected]>
Since arm64 can't use gclient to sync dependencies Signed-off-by: RJ Sampson <[email protected]>
Signed-off-by: RJ Sampson <[email protected]>
Signed-off-by: RJ Sampson <[email protected]>
Signed-off-by: RJ Sampson <[email protected]>
a8efe2a to
e502af8
Compare
|
Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation. To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify: e.g. /ai-verify partially helpful but I also added bash to the build environment Gen AI suggestions to solve the build error: • Detected Error: "ninja: file is missing and not created by any action: '../../third_party/node/linux/node-linux-x64/bin/node'" • Error Category: Dependency • Failure Point: The ninja build system cannot find the Node.js binary that was supposed to be symlinked earlier • Root Cause Analysis: The symlink creation to the system Node.js binary failed or the system Node.js is not available as expected • Suggested Fix:
environment:
contents:
packages:
- nodejs
# ... existing packages ...
# Use host node
mkdir -p third_party/node/linux/node-linux-x64/bin
ln -sf $(which node) third_party/node/linux/node-linux-x64/bin/node• Explanation: Chromium's build system expects Node.js to be available at a specific path. The current symlink attempt fails because either Node.js isn't installed in the build environment or the symlink creation isn't working correctly. Adding nodejs to the environment packages ensures it's available, and using $(which node) ensures we link to the correct binary path. • Additional Notes:
• References: |
Signed-off-by: RJ Sampson <[email protected]>
de787d8 to
3824a70
Compare
Signed-off-by: RJ Sampson <[email protected]>
3824a70 to
90e339f
Compare
jamonation
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
These changes implement support for arm64 in our builds of Chromium. Here are the changes at a high level: