-
Notifications
You must be signed in to change notification settings - Fork 416
libmamba: Use semver tags #40521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libmamba: Use semver tags #40521
Conversation
1804a7d to
5da0d34
Compare
sil2100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good. @murraybd 's question about openjdk in withdrawals is the only thing that I'd like to understand first, but other than that - it's good to go.
Signed-off-by: dann frazier <[email protected]>
5da0d34 to
ebbb1f7
Compare
We were tracking the date-based tags, but these tags are not always forward-moving. Switch to the semver tags instead. Patch is adjusted for context, and a reference to its origin is added. Signed-off-by: dann frazier <[email protected]>
ebbb1f7 to
b1774d4
Compare
Fixed that one |
We've been using the date-based tags, which don't appear to represent releases. In fact, they sometimes move the code backwards. Let's switch to the semver based tags. This requires withdrawing the previous builds since the date based tags sort greater than the semver ones.
We're using the
libmamba-<version>tags here, but note that upstream also providesmicromamba-<version>andlibmambapy-<version>tags. While they all point to the same commits today, it is possible that will not always be the case. I attempted to split these into separate YAML files but ran into some issues buildingmicromambaagainst a system install oflibmamba-dev, so let's hold off on that for now.Fixes: #38649