Skip to content

Conversation

@dannf
Copy link
Member

@dannf dannf commented Jan 25, 2025

We've been using the date-based tags, which don't appear to represent releases. In fact, they sometimes move the code backwards. Let's switch to the semver based tags. This requires withdrawing the previous builds since the date based tags sort greater than the semver ones.

We're using the libmamba-<version> tags here, but note that upstream also provides micromamba-<version> and libmambapy-<version> tags. While they all point to the same commits today, it is possible that will not always be the case. I attempted to split these into separate YAML files but ran into some issues building micromamba against a system install of libmamba-dev, so let's hold off on that for now.

Fixes: #38649

@dannf dannf enabled auto-merge January 25, 2025 18:57
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Jan 25, 2025
@dannf dannf force-pushed the libmamba-semver branch 2 times, most recently from 1804a7d to 5da0d34 Compare January 27, 2025 21:56
Copy link
Member

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. @murraybd 's question about openjdk in withdrawals is the only thing that I'd like to understand first, but other than that - it's good to go.

We were tracking the date-based tags, but these tags are not
always forward-moving. Switch to the semver tags instead.

Patch is adjusted for context, and a reference to its origin is added.

Signed-off-by: dann frazier <[email protected]>
@dannf
Copy link
Member Author

dannf commented Jan 28, 2025

The PR looks good. @murraybd 's question about openjdk in withdrawals is the only thing that I'd like to understand first, but other than that - it's good to go.

Fixed that one

@dannf dannf merged commit 20d4c6d into wolfi-dev:main Jan 29, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libmamba fails to build on amd64

4 participants