ruby3.2-validate_url: unbreak at HEAD.
#3853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawlingsj
previously approved these changes
Jul 24, 2023
Member
Author
|
Removing from merge queue because I just had an idea that might clean this up a little bit. I want to see if it works, and if not let's go with this, but if it does work then I'll be 💯 happier 🤞 |
This fixes an issue with `ruby3.2-validate_url` where the `git clone {url} .` was failing at HEAD because the directory isn't empty (it has `lost+found`).
To address this, I played around with a few options, but ended up adapting a forked version of our current `git-checkout` pipeline.
This also moves 1.0.15 one commit ahead to let us drop the `sed` command, since they updated the upstream repo with a superset of this change.
Signed-off-by: Matt Moore <[email protected]>
mattmoor
force-pushed
the
fix-ruby-validate-url
branch
from
c2a4f1f to
6677b72
Compare
Member
Author
|
Ok, I switched to |
ajayk
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with
ruby3.2-validate_urlwhere thegit clone {url} .was failing at HEAD because the directory isn't empty (it haslost+found).To address this, I played around with a few options, but ended up adapting a forked version of our current
git-checkoutpipeline.This also moves 1.0.15 one commit ahead to let us drop the
sedcommand, since they updated the upstream repo with a superset of this change.