gnutls: fix underlinking #3803
Merged
gnutls: fix underlinking #3803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with -Wl,-z,now, all symbols must be resolved at link time, as lazy binding is disabled. This provides better performance and also provides protections when combined with -z relro against segments being overwritten at runtime. However, there is a bug in the GNUTLS build, where the p11-kit symbols are not linked by the pkg-config file normally, allowing the dependency to be resolved through lazy binding instead. Fix this by adding a Requires relationship on the p11-kit package in the pkg-config file. Signed-off-by: Ariadne Conill <[email protected]>
Contributor
Package gnutls-doc: Click to expand/collapsePackage gnutls-doc: Package gnutls-dev: Click to expand/collapsePackage gnutls-dev: Package gnutls-utils: Click to expand/collapsePackage gnutls-utils: Package gnutls-c++: Click to expand/collapsePackage gnutls-c++: Package gnutls: Click to expand/collapsePackage gnutls: |
mattmoor
approved these changes
Jul 21, 2023
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with
-Wl,-z,now, all symbols must be resolved at link time, as lazy binding is disabled. This provides better performance and also provides protections when combined with-z relroagainst segments being overwritten at runtime.However, there is a bug in the GNUTLS build, where the p11-kit symbols are not linked by the pkg-config file normally, allowing the dependency to be resolved through lazy binding instead. Fix this by adding a Requires relationship on the p11-kit package in the pkg-config file.
Fixes: proxysql failure to rebuild from source
cc @mattmoor