Skip to content

use ${{build.arch}} in favor of unset envs #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshrwolf merged 1 commit into from
Jul 17, 2023
Merged

use ${{build.arch}} in favor of unset envs #3656

joshrwolf merged 1 commit into from
Jul 17, 2023

Conversation

@joshrwolf
Copy link
Member

@joshrwolf joshrwolf commented Jul 17, 2023 •
edited
Loading

use the builtin ${{build.arch}} instead of relying on setting $ARCH (which was unset 😬)

@joshrwolf
use ${{build.arch}} in favor of unset envs
1b31056 
Signed-off-by: Josh Wolf <josh@wolfs.io>
@joshrwolf joshrwolf requested a review from a team as a code owner July 17, 2023 15:21
@joshrwolf joshrwolf requested review from deitch and jonjohnsonjr July 17, 2023 15:21
@joshrwolf joshrwolf enabled auto-merge July 17, 2023 16:37
@joshrwolf joshrwolf added this pull request to the merge queue Jul 17, 2023
Merged via the queue into wolfi-dev:main with commit 5dd5b83 Jul 17, 2023
@joshrwolf joshrwolf deleted the calico-arch branch July 17, 2023 17:20
@joshrwolf joshrwolf restored the calico-arch branch July 17, 2023 17:22
@philroche philroche mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deitch deitch Awaiting requested review from deitch deitch was automatically assigned from wolfi-dev/wolfi-repository-maintainers

@jonjohnsonjr jonjohnsonjr Awaiting requested review from jonjohnsonjr jonjohnsonjr was automatically assigned from wolfi-dev/wolfi-repository-maintainers

1 more reviewer

@kaniini kaniini kaniini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshrwolf @kaniini