Skip to content

new package: ko-fips #3579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
imjasonh merged 6 commits into from
Jul 14, 2023
Merged

new package: ko-fips #3579

imjasonh merged 6 commits into from
Jul 14, 2023

Conversation

@imjasonh
Copy link
Member

@imjasonh imjasonh commented Jul 13, 2023

This is mainly a trial run to get an idea for how we can build FIPS-compliant Go packages and images, starting with a Go application we know and understand well.

Once we've proven this out we can move on to more interesting FIPSified Go applications.

@imjasonh
new package: ko-fips
6a08f28 
Signed-off-by: Jason Hall <[email protected]>
@imjasonh imjasonh requested a review from mattmoor July 13, 2023 13:03
@imjasonh imjasonh requested a review from a team as a code owner July 13, 2023 13:03
@imjasonh imjasonh requested a review from joshrwolf July 13, 2023 13:03
@imjasonh
Copy link
Member Author

imjasonh commented Jul 13, 2023

go-fips conflicts with the builtin go/build pipeline, good to know. ⭐

@imjasonh
don't use go/build
f5a3ae2 
Signed-off-by: Jason Hall <[email protected]>
@mattmoor
Copy link
Member

mattmoor commented Jul 13, 2023

What's the best option? go-fips/build? :)

@imjasonh
Copy link
Member Author

imjasonh commented Jul 13, 2023

What's the best option? go-fips/build? :)

For now I'm just going to do it with runs:, but yeah, we might consider having a go-fips variant, probably only in the wolfi-os repo, rather than built into melange like go/build is.

@imjasonh
just use a local pipeline
8e46304 
Signed-off-by: Jason Hall <[email protected]>
@imjasonh imjasonh requested a review from a team as a code owner July 13, 2023 15:47
@imjasonh imjasonh requested review from kaniini and removed request for joshrwolf July 13, 2023 15:47
kaniini
kaniini previously approved these changes Jul 13, 2023
View reviewed changes
mattmoor
mattmoor reviewed Jul 13, 2023
View reviewed changes
mattmoor
mattmoor reviewed Jul 13, 2023
View reviewed changes
mattmoor
mattmoor reviewed Jul 13, 2023
View reviewed changes
@imjasonh @mattmoor
Update ko-fips.yaml
bd35f95 
Co-authored-by: Matt Moore <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
@imjasonh @mattmoor
Update ko-fips.yaml
f0010e3 
Co-authored-by: Matt Moore <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
@imjasonh imjasonh enabled auto-merge July 13, 2023 16:38
@imjasonh imjasonh mentioned this pull request Jul 14, 2023
Merged
@imjasonh imjasonh added this pull request to the merge queue Jul 14, 2023
Merged via the queue into wolfi-dev:main with commit 1bab2d5 Jul 14, 2023
@imjasonh imjasonh deleted the ko-fips branch July 14, 2023 01:15
@philroche philroche mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattmoor mattmoor mattmoor left review comments

@luhring luhring luhring approved these changes

+1 more reviewer

@kaniini kaniini kaniini left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@imjasonh @mattmoor @kaniini @luhring