move bash completions into separate subpackage #3369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrwolf
force-pushed
the
kubectl-completions
branch
from
96f5676 to
9b6a0cc
Compare
Signed-off-by: Josh Wolf <[email protected]>
joshrwolf
force-pushed
the
kubectl-completions
branch
from
9b6a0cc to
d8a0c1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on the off chance we want the bash completions, keep them around but in a sub package.
this fixes the version conflicts between the bash completions, and brings them in line with the way we deconflict the clis