Skip to content

update ingress-nginx build to work with ingress-nginx image #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
strongjz merged 6 commits into from
Jul 19, 2023
Merged

update ingress-nginx build to work with ingress-nginx image #3335

strongjz merged 6 commits into from
Jul 19, 2023

Conversation

@strongjz
Copy link

@strongjz strongjz commented Jul 3, 2023 •
edited
Loading

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • REQUIRED - The package is added to packages.txt

For security-related PRs

For version bump PRs

@strongjz strongjz requested a review from a team as a code owner July 3, 2023 19:25
@strongjz strongjz requested review from ajayk and imjasonh July 3, 2023 19:25
@strongjz strongjz enabled auto-merge July 3, 2023 19:29
@rawlingsj
Copy link
Member

rawlingsj commented Jul 4, 2023

Might be good for @amouat to take a look at this one too as I know you've spent some time looking at nginx.

rawlingsj
rawlingsj reviewed Jul 4, 2023
View reviewed changes
@strongjz strongjz force-pushed the update-ingress branch 5 times, most recently from 2fdeee2 to 97802fa Compare July 12, 2023 13:06
James Strong and others added 5 commits July 19, 2023 14:53
fixes while building image
0ee1a2a 
Signed-off-by: James Strong <[email protected]>
moved ingress-nginx build into ingress-nginx-controller
4cfe305 
Signed-off-by: James Strong <[email protected]>
move things around for testing
faa897f 
Signed-off-by: James Strong <[email protected]>
testing fix
e8a8800 
Signed-off-by: James Strong <[email protected]>
update testing
e846d41 
Signed-off-by: James Strong <[email protected]>
@joshrwolf joshrwolf force-pushed the update-ingress branch 3 times, most recently from e14ecfa to 4b009b2 Compare July 19, 2023 20:34
@joshrwolf
fix woflictl linting
8e29976 
Signed-off-by: Josh Wolf <[email protected]>
@strongjz strongjz added this pull request to the merge queue Jul 19, 2023
Merged via the queue into wolfi-dev:main with commit bd1ebd0 Jul 19, 2023
@strongjz strongjz deleted the update-ingress branch July 19, 2023 23:04
@philroche philroche mentioned this pull request Aug 29, 2024
Merged
@philroche philroche mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rawlingsj rawlingsj rawlingsj left review comments

@joshrwolf joshrwolf joshrwolf approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh imjasonh was automatically assigned from wolfi-dev/wolfi-repository-maintainers

@ajayk ajayk Awaiting requested review from ajayk ajayk was automatically assigned from wolfi-dev/wolfi-repository-maintainers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@strongjz @rawlingsj @joshrwolf