Add new: Packages for Kubernetesui-dashboard #32291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditvil-Dev <[email protected]>
Signed-off-by: Aditvil-Dev <[email protected]>
Signed-off-by: Aditvil-Dev <[email protected]>
kranurag7
requested changes
Oct 30, 2024
Member
kranurag7
left a comment
kranurag7
left a comment
There was a problem hiding this comment.
great work!! left some comments inline.
Signed-off-by: Aditvil-Dev <[email protected]>
kranurag7
requested changes
Oct 30, 2024
Member
kranurag7
left a comment
kranurag7
left a comment
There was a problem hiding this comment.
requesting some more changes around ldflags.
We can also extend the tests if the CLI is exposing version via version or --version and then grep it. foo --version | grep ${{package.version}}
Signed-off-by: Aditvil-Dev <[email protected]>
Member
Author
|
There is no |
kranurag7
approved these changes
Oct 30, 2024
Member
kranurag7
left a comment
kranurag7
left a comment
There was a problem hiding this comment.
Nice Work!! thanks for being patient with the reviews. looks good to me.
Aditevil
added a commit
to Aditevil/os
that referenced
this pull request
Oct 30, 2024
<!---
Provide a short summary in the Title above. Examples of good PR titles:
* "ruby-3.1: new package"
* "haproxy: fix CVE-2014-123456"
-->
<!--
Please include references to any related issues or delete this section
otherwise.
-->
Fixes:
Related:
### Pre-review Checklist
<!--
This checklist is mostly useful as a reminder of small things that can
easily be
forgotten – it is meant as a helpful tool rather than hoops to jump
through.
At the moment of this PR you have the most information on what all the
change
will affect, so please take the time to jot it down.
Put an `x` in all the items that apply, make notes next to any that
haven't been
addressed, and remove any items that are not relevant to this PR.
-->
#### For new package PRs only
<!-- remove if unrelated -->
- [ ] This PR is marked as fixing a pre-existing package request bug
- [ ] Alternatively, the PR is marked as related to a pre-existing
package request bug, such as a dependency
- [x] REQUIRED - The package is available under an OSI-approved or
FSF-approved license
- [x] REQUIRED - The version of the package is still receiving security
updates
- [ ] This PR links to the upstream project's support policy (e.g.
`endoflife.date`)
#### For new version streams
<!-- remove if unrelated -->
- [ ] The upstream project actually supports multiple concurrent
versions.
- [ ] Any subpackages include the version string in their package name
(e.g. `name: ${{package.name}}-compat`)
- [ ] The package (and subpackages) `provides:` logical unversioned
forms of the package (e.g. `nodejs`, `nodejs-lts`)
- [ ] If non-streamed package names no longer built, open PR to withdraw
them (see [WITHDRAWING
PACKAGES](https://github.com/wolfi-dev/os/blob/main/WITHDRAWING_PACKAGES.md))
#### For package updates (renames) in the base images
<!-- remove if unrelated -->
When updating packages part of base images (i.e.
cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)
- [ ] REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk
images successfully build
- [ ] REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk
contain no obsolete (no longer built) packages
- [ ] Upon launch, does `apk upgrade --latest` successfully upgrades
packages or performs no actions
#### For security-related PRs
<!-- remove if unrelated -->
- [ ] The security fix is recorded in the
[advisories](https://github.com/wolfi-dev/advisories) repo
#### For version bump PRs
<!-- remove if unrelated -->
- [x] The `epoch` field is reset to 0
#### For PRs that add patches
<!-- remove if unrelated -->
- [ ] Patch source is documented
---------
Signed-off-by: Aditvil-Dev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Related:
Pre-review Checklist
For new package PRs only
endoflife.date)For new version streams
name: ${{package.name}}-compat)provides:logical unversioned forms of the package (e.g.nodejs,nodejs-lts)For package updates (renames) in the base images
When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)
apk upgrade --latestsuccessfully upgrades packages or performs no actionsFor security-related PRs
For version bump PRs
epochfield is reset to 0For PRs that add patches