Skip to content

Conversation

@developer-guy
Copy link
Member

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • REQUIRED - The package is added to packages.txt

For security-related PRs

  • The security fix is recorded in advisories and secfixes

For version bump PRs

  • The epoch field is reset to 0
  • Patch source: patch source here

@developer-guy developer-guy requested a review from a team as a code owner June 25, 2023 17:29
@developer-guy developer-guy force-pushed the feature/ghostscript branch 4 times, most recently from 3673d47 to 30a61fd Compare June 25, 2023 17:37
imjasonh
imjasonh previously approved these changes Jun 26, 2023
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change lgtm but I think the update check is telling us wolfibot won't be able to update it for us:

time="2023-06-25T17:37:34Z" level=fatal msg="error during command execution: 1 error occurred:\n\t* package ghostscript: failed to validate update config, melange bump: got 404 Not Found when fetching [https://github.com/ArtifexSoftware/ghostpdl-downloads/releases/download/gs${{vars.mangled-package-version}}/ghostscript-10.01.2.tar.gz\n\n](https://github.com/ArtifexSoftware/ghostpdl-downloads/releases/download/gs$%7B%7Bvars.mangled-package-version%7D%7D/ghostscript-10.01.2.tar.gz/n/n)"

@developer-guy
Copy link
Member Author

developer-guy commented Jun 26, 2023

The change lgtm but I think the update check is telling us wolfibot won't be able to update it for us:

time="2023-06-25T17:37:34Z" level=fatal msg="error during command execution: 1 error occurred:\n\t* package ghostscript: failed to validate update config, melange bump: got 404 Not Found when fetching [https://github.com/ArtifexSoftware/ghostpdl-downloads/releases/download/gs${{vars.mangled-package-version}}/ghostscript-10.01.2.tar.gz\n\n](https://github.com/ArtifexSoftware/ghostpdl-downloads/releases/download/gs$%7B%7Bvars.mangled-package-version%7D%7D/ghostscript-10.01.2.tar.gz/n/n)"

is this some sort of a bug in wolfictl check update command? Because it seems that it couldn't replace this part ${{vars.mangled-package-version}}🤔 PTAL @Dentrax

@rawlingsj
Copy link
Member

The cause of the issue is the var substitution isn’t taking place during a melange bump. The reason for that is the way the melange packages are structured as a cyclic package dependency occurs when melange bump calls the var replace code.

Until this is resolved we've been merging with that failed check as it isn’t a “required” check.

What you can do is change the update section to manual: true

@developer-guy developer-guy force-pushed the feature/ghostscript branch 2 times, most recently from 2abddbc to 5881f4f Compare June 29, 2023 12:19
@developer-guy developer-guy force-pushed the feature/ghostscript branch 7 times, most recently from a28bcf4 to a8cf90b Compare July 4, 2023 09:06
@developer-guy developer-guy force-pushed the feature/ghostscript branch 4 times, most recently from 1570ffd to eca65b9 Compare July 4, 2023 09:58
@rawlingsj rawlingsj added this pull request to the merge queue Jul 4, 2023
Signed-off-by: Batuhan Apaydin <[email protected]>
Co-authored-by: Furkan Turkal <[email protected]>
Signed-off-by: Batuhan Apaydin <[email protected]>
@developer-guy developer-guy force-pushed the feature/ghostscript branch from eca65b9 to d68b205 Compare July 4, 2023 10:19
Merged via the queue into wolfi-dev:main with commit 2e67145 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants