Skip to content

Selenium nodechrome 3765 #30970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
utieyin merged 43 commits into from
Oct 30, 2024
Merged

Selenium nodechrome 3765 #30970

utieyin merged 43 commits into from
Oct 30, 2024

Conversation

@utieyin
Copy link
Contributor

@utieyin utieyin commented Oct 16, 2024

An example config and several subpackages now exist for creating multiple components of docker-selenium

Pre-review Checklist

For new package PRs only

  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates

Dentrax
Dentrax reviewed Oct 17, 2024
View reviewed changes
maxgio92
maxgio92 reviewed Oct 17, 2024
View reviewed changes
@utieyin utieyin marked this pull request as ready for review October 17, 2024 13:02
EyeCantCU
EyeCantCU reviewed Oct 17, 2024
View reviewed changes
EyeCantCU
EyeCantCU requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change, otherwise looks good

@utieyin utieyin requested a review from EyeCantCU October 22, 2024 15:31
EyeCantCU
EyeCantCU previously requested changes Oct 22, 2024
View reviewed changes
@utieyin utieyin requested a review from EyeCantCU October 29, 2024 14:27
Dentrax
Dentrax reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@Dentrax Dentrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and nice tests! Dropped a few comments.

@utieyin @Dentrax
Update docker-selenium.yaml
8882823 
Co-authored-by: Furkan Türkal <[email protected]>
Signed-off-by: uti <[email protected]>
@utieyin utieyin requested a review from Dentrax October 29, 2024 17:49
maxgio92
maxgio92 reviewed Oct 30, 2024
View reviewed changes
@utieyin
fixed typo
57062ee 
Signed-off-by: uti <[email protected]>
@utieyin
fixing more typos
f9b548f 
Signed-off-by: uti <[email protected]>
@utieyin utieyin requested a review from maxgio92 October 30, 2024 09:55
@maxgio92
Copy link
Member

maxgio92 commented Oct 30, 2024

Great work!

@utieyin utieyin merged commit 25d123b into wolfi-dev:main Oct 30, 2024
@utieyin utieyin deleted the selenium-nodechrome-3765 branch October 30, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxgio92 maxgio92 maxgio92 approved these changes

@EyeCantCU EyeCantCU Awaiting requested review from EyeCantCU

@Dentrax Dentrax Awaiting requested review from Dentrax

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@utieyin @maxgio92 @Dentrax @EyeCantCU