add librdkafka #2822
Merged
add librdkafka #2822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developer-guy
force-pushed
the
feature/librdkafka
branch
2 times, most recently
from
aa2e30c to
0894046
Compare
Signed-off-by: Batuhan Apaydin <[email protected]> Co-authored-by: Furkan Turkal <[email protected]> Signed-off-by: Batuhan Apaydin <[email protected]>
developer-guy
force-pushed
the
feature/librdkafka
branch
from
0894046 to
1202693
Compare
kaniini
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Related:
Pre-review Checklist
For new package PRs only
packages.txtFor security-related PRs
advisoriesandsecfixesFor version bump PRs
epochfield is reset to 0IMPORTANT NOTES for the reviewer :
I'm actually trying to build kafkacat, librdkafka is one of the dependencies of that package, but when I try to librdkafka, I noticed that it depends on another package we don't have yet named rapidjson, but without adding that dependency, it worked somehow, so the question is should I still build rapidjson package and add it to its dependencies?