Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt/11.0.1 package update #23233

Closed
wants to merge 2 commits into from
Closed

fmt/11.0.1 package update #23233

wants to merge 2 commits into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Jul 5, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Jul 5, 2024
@octo-sts octo-sts bot mentioned this pull request Jul 5, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Package fmt: Click to expand/collapse

Package fmt:
Added: /usr/lib/libfmt.so.11.0.1
Deleted: /usr/lib/libfmt.so.10.2.1

Package fmt-dev: Click to expand/collapse

Package fmt-dev:
Added: /usr/include/fmt/base.h
Modified: /usr/include/fmt/args.h
Modified: /usr/include/fmt/chrono.h
Modified: /usr/include/fmt/color.h
Modified: /usr/include/fmt/compile.h
Modified: /usr/include/fmt/core.h
Modified: /usr/include/fmt/format-inl.h
Modified: /usr/include/fmt/format.h
Modified: /usr/include/fmt/os.h
Modified: /usr/include/fmt/ostream.h
Modified: /usr/include/fmt/printf.h
Modified: /usr/include/fmt/ranges.h
Modified: /usr/include/fmt/std.h
Modified: /usr/include/fmt/xchar.h
Modified: /usr/lib/cmake/fmt/fmt-config-version.cmake
Modified: /usr/lib/cmake/fmt/fmt-targets-minsizerel.cmake
Modified: /usr/lib/pkgconfig/fmt.pc

bincapz found differences: Click to expand/collapse

Added: fmt-dev/usr/include/fmt/base.h [✅ LOW]

RISK KEY DESCRIPTION EVIDENCE
+LOW ref/site/url contains embedded HTTPS URLs https://fmt.dev/latest/api.html
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59884
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61414
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67371.
fmtlib/fmt#1628
fmtlib/fmt#3247
fmtlib/fmt#3796
fmtlib/fmt#2297
fmtlib/fmt#2582
https://godbolt.org/z/GvWzcTjh1.
https://godbolt.org/z/sWw4vP.
https://herbsutter.com/2009/10/18/mailbag-shutting-up-compiler-warnings/.

@octo-sts Octo STS
Copy link
Contributor Author

octo-sts bot commented Jul 5, 2024

Open AI suggestions to solve the build error:

No errors were found in the log file. If you need further assistance, please ensure the log file path is correct and verify that the log file contains error messages.

@octo-sts Octo STS
Copy link
Contributor Author

octo-sts bot commented Jul 6, 2024

Open AI suggestions to solve the build error:

The error message is: "INFO /home/build/micromamba/src/run.cpp:76:40: error: 'join' is not a member of 'fmt'; did you mean 'CLI::detail::join'?
INFO    76 |                 fmt::format(\"{}\", fmt::join(el[\"command\"].get<std::vector<std::string>>(), \" \")),
INFO       |                                        ^~~~
INFO In file included from /usr/include/CLI/CLI.hpp:22,
INFO                  from /home/build/micromamba/src/common_options.hpp:10,
INFO                  from /home/build/micromamba/src/run.cpp:24:
INFO /usr/include/CLI/StringTools.hpp:69:13: note: 'CLI::detail::join' declared here
INFO    69 | std::string join(const T &v, Callable func, std::string delim = \",\") {
INFO       |             ^~~~
INFO /home/build/micromamba/src/run.cpp:72:26: error: cannot convert '<brace-enclosed initializer list>' to 'const std::vector<mamba::printers::FormattedString>&'
INFO    72 |             table.add_row({
INFO       |             ~~~~~~~~~~~~~^~
INFO    73 |                 el[\"pid\"].get<std::string>(),
INFO       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
INFO    74 |                 el[\"name\"].get<std::string>(),
INFO       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
INFO    75 |                 prefix,
INFO       |                 ~~~~~~~   
WARN ninja: job failed: /usr/bin/c++ -DFMT_SHARED -DSPDLOG_FMT_EXTERNAL -I/home/build/libmamba/include -isystem /usr/share -O2 -Wall -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -march=armv8-a+crc+crypto -mtune=neoverse-n1 -O3 -DNDEBUG -std=gnu++17 -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wold-style-cast -Wcast-align -Wunused -Woverloaded-virtual -Wpedantic -Wconversion -Wsign-conversion -Wnull-dereference -Wdouble-promotion -Wformat=2 -Wunreachable-code -Wuninitialized -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Wuseless-cast -MD -MT micromamba/CMakeFiles/micromamba.dir/src/run.cpp.o -MF micromamba/CMakeFiles/micromamba.dir/src/run.cpp.o.d -o micromamba/CMakeFiles/micromamba.dir/src/run.cpp.o -c /home/build/micromamba/src/run.cpp
INFO    76 |                 fmt::format(\"{}\", fmt::join(el[\"command\"].get<std::vector<std::string>>(), \" \")),
INFO       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
INFO    77 |             });
INFO       |             ~~            
INFO In file included from /home/build/libmamba/include/mamba/core/util_scope.hpp:7,
INFO                  from /home/build/libmamba/include/mamba/core/tasksync.hpp:16,
INFO                  from /home/build/libmamba/include/mamba/core/context.hpp:19,
INFO                  from /home/build/libmamba/include/mamba/api/configuration_impl.hpp:11,
INFO                  from /home/build/libmamba/include/mamba/api/configuration.hpp:14,
INFO                  from /home/build/micromamba/src/run.cpp:17:
INFO /home/build/libmamba/include/mamba/core/output.hpp:84:62: note:   initializing argument 1 of 'void mamba::printers::Table::add_row(const std::vector<mamba::printers::FormattedString>&)'
INFO    84 |             void add_row(const std::vector<FormattedString>& r);
INFO       |                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
INFO In file included from /home/build/libmamba/include/mamba/api/install.hpp:22,
INFO                  from /home/build/micromamba/src/install.cpp:2:
INFO /home/build/libmamba/include/mamba/core/repo.hpp:91:59: warning: 'PyExtraPkgInfo' is deprecated [-Wdeprecated-declarations]
INFO    91 |         py_add_extra_pkg_info(const std::map<std::string, PyExtraPkgInfo>& additional_info);
INFO       |                                                           ^~~~~~~~~~~~~~
INFO /home/build/libmamba/include/mamba/core/repo.hpp:80:31: note: declared here
INFO    80 |         struct [[deprecated]] PyExtraPkgInfo
INFO       |                               ^~~~~~~~~~~~~~
INFO In file included from /home/build/libmamba/include/mamba/api/install.hpp:22,
INFO                  from /home/build/libmamba/include/mamba/core/transaction.hpp:14,
INFO                  from /home/build/micromamba/src/update.cpp:16:
INFO /home/build/libmamba/include/mamba/core/repo.hpp:91:59: warning: 'PyExtraPkgInfo' is deprecated [-Wdeprecated-declarations]
INFO    91 |         py_add_extra_pkg_info(const std::map<std::string, PyExtraPkgInfo>& additional_info);
INFO       |                                                           ^~~~~~~~~~~~~~
INFO /home/build/libmamba/include/mamba/core/repo.hpp:80:31: note: declared here
INFO    80 |         struct [[deprecated]] PyExtraPkgInfo
INFO       |                               ^~~~~~~~~~~~~~
INFO In file included from /home/build/libmamba/include/mamba/api/install.hpp:22,
INFO                  from /home/build/micromamba/src/constructor.cpp:11:
INFO /home/build/libmamba/include/mamba/core/repo.hpp:91:59: warning: 'PyExtraPkgInfo' is deprecated [-Wdeprecated-declarations]
INFO    91 |         py_add_extra_pkg_info(const std::map<std::string, PyExtraPkgInfo>& additional_info);
INFO       |                                                           ^~~~~~~~~~~~~~
INFO /home/build/libmamba/include/mamba/core/repo.hpp:80:31: note: declared here
INFO    80 |         struct [[deprecated]] PyExtraPkgInfo
INFO       |                               ^~~~~~~~~~~~~~
INFO /home/build/micromamba/src/constructor.cpp: In function 'void read_binary_from_stdin_and_write_to_file(fs::u8path&)':
INFO /home/build/micromamba/src/constructor.cpp:219:41: warning: conversion to 'std::streamsize' {aka 'long int'} from 'std::size_t' {aka 'long unsigned int'} may change the sign of the result [-Wsign-conversion]
INFO   219 |         out_stream.write(buffer.data(), len);
INFO       |                                         ^~~
WARN ninja: subcommand failed
ERRO ERROR: failed to build package. the build environment has been preserved:
INFO   workspace dir: /temp/melange-workspace-3011360955
INFO   guest dir: /temp/melange-guest-1079975923
ERRO failed to build package: unable to run package libmamba pipeline: unable to run pipeline: unable to run pipeline: exit status 1
make[1]: *** [Makefile:111: packages/aarch64/libmamba-2024.03.25-r3.apk] Error 1
make[1]: Leaving directory '/github/home'
make: *** [Makefile:101: package/libmamba] Error 2
##[error]Process completed with exit code 2."

1. Replace `fmt::join` with `CLI::detail::join` in `/home/build/micromamba/src/run.cpp`.
2. Ensure `CLI/StringTools.hpp` is included.
3. Convert the initializer list to a `std::vector<mamba::printers::FormattedString>` before passing to `table.add_row`.
4. Rebuild the project.

@mamccorm mamccorm force-pushed the wolfictl-8d160550-b53e-42db-aeb5-adff1690f810 branch from d426ed1 to 5fc20ba Compare July 15, 2024 21:43
@mamccorm mamccorm force-pushed the wolfictl-8d160550-b53e-42db-aeb5-adff1690f810 branch from 5fc20ba to 25e5327 Compare July 15, 2024 21:44
@octo-sts Octo STS
Copy link
Contributor Author

octo-sts bot commented Jul 15, 2024

Open AI suggestions to solve the build error:

The error message is: "INFO /home/build/micromamba/src/run.cpp:76:40: error: 'join' is not a member of 'fmt'; did you mean 'CLI::detail::join'?
INFO    76 |                 fmt::format(\"{}\", fmt::join(el[\"command\"].get<std::vector<std::string>>(), \" \")),
INFO       |                                        ^~~~
INFO In file included from /usr/include/CLI/CLI.hpp:22,
INFO                  from /home/build/micromamba/src/common_options.hpp:10,
WARN ninja: job failed: /usr/bin/c++ -DFMT_SHARED -DSPDLOG_FMT_EXTERNAL -I/home/build/libmamba/include -isystem /usr/share -O2 -Wall -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -march=armv8-a+crc+crypto -mtune=neoverse-n1 -O3 -DNDEBUG -std=gnu++17 -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wold-style-cast -Wcast-align -Wunused -Woverloaded-virtual -Wpedantic -Wconversion -Wsign-conversion -Wnull-dereference -Wdouble-promotion -Wformat=2 -Wunreachable-code -Wuninitialized -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Wuseless-cast -MD -MT micromamba/CMakeFiles/micromamba.dir/src/run.cpp.o -MF micromamba/CMakeFiles/micromamba.dir/src/run.cpp.o.d -o micromamba/CMakeFiles/micromamba.dir/src/run.cpp.o -c /home/build/micromamba/src/run.cpp"

1. Ensure you have included the correct header for `fmt::join`. It should be `#include <fmt/ranges.h>`.
2. Verify that the `fmt` library version you are using supports `fmt::join`.
3. If the issue persists, update the `fmt` library to the latest version.
4. Replace `fmt::join` with `CLI::detail::join` if `fmt::join` is not available.

@octo-sts Octo STS
Copy link
Contributor Author

octo-sts bot commented Jul 15, 2024

Open AI suggestions to solve the build error:

The error message is: "INFO /home/build/micromamba/src/run.cpp:76:40: error: 'join' is not a member of 'fmt'; did you mean 'CLI::detail::join'?\nINFO    76 |                 fmt::format(\"{}\", fmt::join(el[\"command\"].get<std::vector<std::string>>(), \" \")),\nINFO       |                                        ^~~~\nINFO In file included from /usr/include/CLI/CLI.hpp:22,\nINFO                  from /home/build/micromamba/src/common_options.hpp:10,\nINFO                  from /home/build/micromamba/src/run.cpp:24:\nINFO /usr/include/CLI/StringTools.hpp:69:13: note: 'CLI::detail::join' declared here\nINFO    69 | std::string join(const T &v, Callable func, std::string delim = \",\") {\nINFO       |             ^~~~\nINFO /home/build/micromamba/src/run.cpp:72:26: error: cannot convert '<brace-enclosed initializer list>' to 'const std::vector<mamba::printers::FormattedString>&'\nINFO    72 |             table.add_row({\nINFO       |             ~~~~~~~~~~~~~^~\nINFO    73 |                 el[\"pid\"].get<std::string>(),\nINFO       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nINFO    74 |                 el[\"name\"].get<std::string>(),\nINFO       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nINFO    75 |                 prefix,\nINFO       |                 ~~~~~~~   \nINFO    76 |                 fmt::format(\"{}\", fmt::join(el[\"command\"].get<std::vector<std::string>>(), \" \")),\nINFO       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nINFO    77 |             });\nINFO       |             ~~            \nINFO In file included from /home/build/libmamba/include/mamba/core/util_scope.hpp:7,\nINFO                  from /home/build/libmamba/include/mamba/core/tasksync.hpp:16,\nINFO                  from /home/build/libmamba/include/mamba/core/context.hpp:19,\nINFO                  from /home/build/libmamba/include/mamba/api/configuration_impl.hpp:11,\nINFO                  from /home/build/libmamba/include/mamba/api/configuration.hpp:14,\nINFO                  from /home/build/micromamba/src/run.cpp:17:\nINFO /home/build/libmamba/include/mamba/core/output.hpp:84:62: note:   initializing argument 1 of 'void mamba::printers::Table::add_row(const std::vector<mamba::printers::FormattedString>&)'\nINFO    84 |             void add_row(const std::vector<FormattedString>& r);\nINFO       |                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^\nWARN ninja: job failed: /usr/bin/c++ -DFMT_SHARED -DSPDLOG_FMT_EXTERNAL -I/home/build/libmamba/include -isystem /usr/share -O2 -Wall -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -march=armv8-a+crc+crypto -mtune=neoverse-n1 -O3 -DNDEBUG -std=gnu++17 -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wold-style-cast -Wcast-align -Wunused -Woverloaded-virtual -Wpedantic -Wconversion -Wsign-conversion -Wnull-dereference -Wdouble-promotion -Wformat=2 -Wunreachable-code -Wuninitialized -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Wuseless-cast -MD -MT micromamba/CMakeFiles/micromamba.dir/src/run.cpp.o -MF micromamba/CMakeFiles/micromamba.dir/src/run.cpp.o.d -o micromamba/CMakeFiles/micromamba.dir/src/run.cpp.o -c /home/build/micromamba/src/run.cpp"

1. Replace `fmt::join` with `CLI::detail::join`.
2. Ensure `CLI/StringTools.hpp` is included.
3. Convert the initializer list to a `std::vector<mamba::printers::FormattedString>` before passing to `table.add_row`.

@octo-sts Octo STS
Copy link
Contributor Author

octo-sts bot commented Jul 15, 2024

Open AI suggestions to solve the build error:

The error message is: "In file included from /home/build/libmamba/include/mamba/api/install.hpp:22, INFO                  from /home/build/micromamba/src/run.cpp:18: INFO /home/build/libmamba/include/mamba/core/repo.hpp:91:59: warning: 'PyExtraPkgInfo' is deprecated [-Wdeprecated-declarations] WARN ninja: job failed: /usr/bin/c++ -DFMT_SHARED -DSPDLOG_FMT_EXTERNAL -I/home/build/libmamba/include -isystem /usr/share -O2 -Wall -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -march=armv8-a+crc+crypto -mtune=neoverse-n1 -O3 -DNDEBUG -std=gnu++17 -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wold-style-cast -Wcast-align -Wunused -Woverloaded-virtual -Wpedantic -Wconversion -Wsign-conversion -Wnull-dereference -Wdouble-promotion -Wformat=2 -Wunreachable-code -Wuninitialized -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Wuseless-cast -MD -MT micromamba/CMakeFiles/micromamba.dir/src/run.cpp.o -MF micromamba/CMakeFiles/micromamba.dir/src/run.cpp.o.d -o micromamba/CMakeFiles/micromamba.dir/src/run.cpp.o -c /home/build/micromamba/src/run.cpp INFO    91 |         py_add_extra_pkg_info(const std::map<std::string, PyExtraPkgInfo>& additional_info); INFO       |                                                           ^~~~~~~~~~~~~~ INFO /home/build/libmamba/include/mamba/core/repo.hpp:80:31: note: declared here INFO    80 |         struct [[deprecated]] PyExtraPkgInfo INFO       |                               ^~~~~~~~~~~~~~ INFO /home/build/micromamba/src/run.cpp: In lambda function: INFO /home/build/micromamba/src/run.cpp:76:40: error: 'join' is not a member of 'fmt'; did you mean 'CLI::detail::join'? INFO    76 |                 fmt::format(\"{}\", fmt::join(el[\"command\"].get<std::vector<std::string>>(), \" \")); INFO       |                                        ^~~~ INFO In file included from /usr/include/CLI/CLI.hpp:22, INFO                  from /home/build/micromamba/src/common_options.hpp:10, INFO                  from /home/build/micromamba/src/run.cpp:24: INFO /usr/include/CLI/StringTools.hpp:69:13: note: 'CLI::detail::join' declared here INFO    69 | std::string join(const T &v, Callable func, std::string delim = \",\") { INFO       |             ^~~~ INFO /home/build/micromamba/src/run.cpp:72:26: error: cannot convert '<brace-enclosed initializer list>' to 'const std::vector<mamba::printers::FormattedString>&' INFO    72 |             table.add_row({ INFO       |             ~~~~~~~~~~~~~^~ INFO    73 |                 el[\"pid\"].get<std::string>(), INFO       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ INFO    74 |                 el[\"name\"].get<std::string>(), INFO       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ INFO    75 |                 prefix, INFO       |                 ~~~~~~~    INFO    76 |                 fmt::format(\"{}\", fmt::join(el[\"command\"].get<std::vector<std::string>>(), \" \")); INFO       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ INFO    77 |             }); INFO       |             ~~             INFO In file included from /home/build/libmamba/include/mamba/core/util_scope.hpp:7, INFO                  from /home/build/libmamba/include/mamba/core/tasksync.hpp:16, INFO                  from /home/build/libmamba/include/mamba/core/context.hpp:19, INFO                  from /home/build/libmamba/include/mamba/api/configuration_impl.hpp:11, INFO                  from /home/build/libmamba/include/mamba/api/configuration.hpp:14, INFO                  from /home/build/micromamba/src/run.cpp:17: INFO /home/build/libmamba/include/mamba/core/output.hpp:84:62: note:   initializing argument 1 of 'void mamba::printers::Table::add_row(const std::vector<mamba::printers::FormattedString>&)' INFO    84 |             void add_row(const std::vector<FormattedString>& r); INFO       |                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ INFO In file included from /home/build/libmamba/include/mamba/api/install.hpp:22, INFO                  from /home/build/micromamba/src/install.cpp:2: INFO /home/build/libmamba/include/mamba/core/repo.hpp:91:59: warning: 'PyExtraPkgInfo' is deprecated [-Wdeprecated-declarations] INFO    91 |         py_add_extra_pkg_info(const std::map<std::string, PyExtraPkgInfo>& additional_info); INFO       |                                                           ^~~~~~~~~~~~~~ INFO /home/build/libmamba/include/mamba/core/repo.hpp:80:31: note: declared here INFO    80 |         struct [[deprecated]] PyExtraPkgInfo INFO       |                               ^~~~~~~~~~~~~~ INFO In file included from /home/build/libmamba/include/mamba/api/install.hpp:22, INFO                  from /home/build/libmamba/include/mamba/core/transaction.hpp:14, INFO                  from /home/build/micromamba/src/update.cpp:16: INFO /home/build/libmamba/include/mamba/core/repo.hpp:91:59: warning: 'PyExtraPkgInfo' is deprecated [-Wdeprecated-declarations] INFO    91 |         py_add_extra_pkg_info(const std::map<std::string, PyExtraPkgInfo>& additional_info); INFO       |                                                           ^~~~~~~~~~~~~~ INFO /home/build/libmamba/include/mamba/core/repo.hpp:80:31: note: declared here INFO    80 |         struct [[deprecated]] PyExtraPkgInfo INFO       |                               ^~~~~~~~~~~~~~ INFO In file included from /home/build/libmamba/include/mamba/api/install.hpp:22, INFO                  from /home/build/micromamba/src/constructor.cpp:11: INFO /home/build/libmamba/include/mamba/core/repo.hpp:91:59: warning: 'PyExtraPkgInfo' is deprecated [-Wdeprecated-declarations] INFO    91 |         py_add_extra_pkg_info(const std::map<std::string, PyExtraPkgInfo>& additional_info); INFO       |                                                           ^~~~~~~~~~~~~~ INFO /home/build/libmamba/include/mamba/core/repo.hpp:80:31: note: declared here INFO    80 |         struct [[deprecated]] PyExtraPkgInfo INFO       |                               ^~~~~~~~~~~~~~ INFO /home/build/micromamba/src/constructor.cpp: In function 'void read_binary_from_stdin_and_write_to_file(fs::u8path&)': INFO /home/build/micromamba/src/constructor.cpp:219:41: warning: conversion to 'std::streamsize' {aka 'long int'} from 'std::size_t' {aka 'long unsigned int'} may change the sign of the result [-Wsign-conversion] INFO   219 |         out_stream.write(buffer.data(), len); INFO       |                                         ^~~ WARN ninja: subcommand failed ERRO ERROR: failed to build package. the build environment has been preserved: INFO   workspace dir: /temp/melange-workspace-3793868023 INFO   guest dir: /temp/melange-guest-3645708913 ERRO failed to build package: unable to run package libmamba pipeline: unable to run pipeline: unable to run pipeline: exit status 1 make[1]: *** [Makefile:111: packages/aarch64/libmamba-2024.03.25-r3.apk] Error 1 make[1]: Leaving directory '/github/home' make: *** [Makefile:101: package/libmamba] Error 2 ##[error]Process completed with exit code 2."

Suggestions to fix the error:
1. Replace `fmt::join` with `CLI::detail::join` in `run.cpp`.
2. Ensure the initializer list in `table.add_row` matches the expected type `std::vector<mamba::printers::FormattedString>`.
3. Update or remove usage of deprecated `PyExtraPkgInfo`.
4. Address the sign-conversion warning in `constructor.cpp` by ensuring the types match.
5. Rebuild the project.

@jamie-albert jamie-albert self-assigned this Jul 19, 2024
@octo-sts octo-sts bot closed this Jul 20, 2024
@octo-sts Octo STS
Copy link
Contributor Author

octo-sts bot commented Jul 20, 2024

superseded by #24349

@octo-sts octo-sts bot deleted the wolfictl-8d160550-b53e-42db-aeb5-adff1690f810 branch July 21, 2024 00:02
jamie-albert
jamie-albert reviewed Aug 1, 2024
View reviewed changes
fmt.yaml
@@ -1,6 +1,6 @@
package:
name: fmt
version: 10.2.1
Copy link
Member

@jamie-albert jamie-albert Aug 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’ve run into an issue where the major version change in fmt, 10.2.1 to 11.0.0 has broken the ability to compile fmt with mamba/libmamba. I am reaching out for eyes with more cpp experience to give insight into if this is something we have the capabilities and bandwidth to address as a patch ourselves or if this is an issue that needs to be addressed upstream.
Here is a link to the actual error itself, the fmt version change log and the commit history of this commit
From what I have looked into these are my concerns.
fmt::join has had its range and iterator overloads moved to fmt/ranges.h. which in an of itself isn’t an issue and could just be a simple import that doesn’t exist currently in the file.
11.0.0 also enabled ADL for begin and end. If I am not mistaken, changing the scope of function lookup might change how iterators are resolved in fmt::join. Is there anyone who has more detailed knowledge of cpp that can verify either way?
Looks like there are some changes to the way the api handles the table.add_row function as the version that was compatible with 10.2.1 no longer satisfies the argument requirements. I didn't feel comfortable blindly attempting the suggested fix in the build failed commit without investigating and understanding the changes that have been made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie-albert jamie-albert jamie-albert left review comments

Assignees

@jamie-albert jamie-albert

Labels
automated pr manual/review-needed request-version-update request for a newer version of a package service:bincapz/pass squad:foundations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamie-albert @TaylorBloom129 @wolfi-bot @rawlingsj