Repository navigation
Conversation
(cherry picked from commit a77c623)
(cherry picked from commit 769102c)
(cherry picked from commit 37aee45)
(cherry picked from commit 8c4363b)
Extract only the bounded planner, host metadata, and precompile controls from source commit 5c353c3. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Hanlin Bi <hanlinb@nvidia.com>
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Bound MiniMax-M3 indexer prefill splits/workspace, build reliable prefill metadata on the host, and precompile expected score variants using existing JIT-warmup controls.
Requested feature extraction from xinli-sw/vllm: maxmax at 3fcc2b022 into
wolfcomos/vllm:main. Extraction baseline:292da21f9d887e7cbd511a648971c7627d83c246. This is a fork-local draft for human review; AI assistance was used for extraction, main compatibility fixes, and validation notes.Claims
5c353c3c, with no index-K sharding or decode-scoring CP.Validation
git diff --check extraction-main...HEAD: passed.tests/kernels/attention/test_minimax_m3_indexer_prefill_split.pywas blocked by missing Torch. No imported-module, SM100 score parity, serving, model evaluation, or performance run completed.GPU/runtime/model validation remains outstanding; this draft is not qualified for upstream submission.
Details
The bounded planner defaults enabled. Precompile follows
kernel_config.enable_jit_warmup, and host metadata is used when its request lengths are reliable. Disabling all split paths requires bothattention_config.minimax_m3_indexer_prefill_kv_split=FalseandVLLM_MINIMAX_M3_INDEXER_PREFILL_KV_SPLIT=0, because the original split fallback remains available.Includes the same
a77c623fprerequisite as the independently based index-K draft; reconcile shared prefill edits when combining them. Source helper files and the source test match the pinnedmaxmaxtip. Precompile currently runs in metadata-builder initialization; moving it into the current warmup registry remains a design review item.Source commits:
a77c623f0,769102cb4,37aee4554,8c4363bbb,5c353c3c0. Original authors and provenance are retained; mixed-feature follow-up commits are included only where specified above.Duplicate-work check: no existing open PRs were present in
wolfcomos/vllmbefore this extraction. Related upstream #59979 covers split-KV/sync-free metadata, while #60930 changes the prefill scorer to CuTe. This is the requested source-version extraction on the user's fork.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Human review of source design and listed tradeoffs is still required.
Testing and Validation: Static/isolated host checks above passed; relevant runtime, GPU, model and performance validation remains outstanding.
Code Quality and Style: Changed-file hooks pass; extraction adaptations are documented.
Pull Request Contents: Source links, scope, duplicate-work context, and validation limits are included.