Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Espressif Update wolfSSL component CMakeLists.txt #6877

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

gojimmypi
Copy link
Contributor

@gojimmypi gojimmypi commented Oct 17, 2023

Description

  • Updates cmake files for wolfssl_benchmark, wolfssl_test, (as well as TLS Client/Server) examples using wolfssl as an Espressif component. Only a CMakeLists.txt file is local to the component; it searches for wolfSSL source.
  • Adds support for per-project user_settings.h.
  • No longer copies user_settings.h into ${WOLFSSL_ROOT}/include/user_settings.h.
  • Includes partitions_singleapp_large.csv for consistency across project examples.

#6844 is currently failing Jenkins tests as the respective CMakeLists.txt checks for both a wolfSSL /include/user_settings.h and a [project]/components/wolfssl/include/user_settings.h. Since those TLS examples support (and in fact, prefer) per-project user_settings.h, the build process fails due to the prior copy of the user_settings.h into /include/user_settings.h by the wolfssl_benchmark build.

  • edit: to resolve the check & egg problem of half the examples expecting (benchmark & test) a local user_settings.h (error if also in root /include), and half expecting shared (TLS Client/Server, not yet updated, see #6844, (Error if also found locally): This update now changes the CmakeLists.txt for all 4 primary examples.

See #6234 for a roadmap of Espressif updates.

Fixes zd# n/a

Testing

How did you test?

manually tested locally

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@gojimmypi
Copy link
Contributor Author

Jenkins retest this please

@JacobBarthelmeh JacobBarthelmeh merged commit c852347 into wolfSSL:master Nov 6, 2023
103 checks passed
@gojimmypi gojimmypi deleted the Espressif-cmake-update branch October 9, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants