JCE: Implements HMAC benchmarks with SHA and MD5 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconlon
requested changes
Feb 7, 2025
jackctj117
force-pushed
the
wolfJSSE_Benchmark
branch
from
7ad7e33 to
e8c10e4
Compare
cconlon
requested changes
Feb 7, 2025
| // Key sizes in bytes based on hash block sizes | ||
| switch (algorithm) { | ||
| case "HmacMD5": | ||
| return 64; |
There was a problem hiding this comment.
These digest sizes are not accurate - take a look at what the native wolfSSL wc_HmacSizeByType() function returns to see the HMAC size by type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added HMAC benchmarking support to CryptoBenchmark