Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various cleanups to tests and documentation #401

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Various cleanups to tests and documentation #401

merged 3 commits into from
Feb 26, 2025

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Feb 22, 2025 •
edited
Loading

  • Added missing doxygen for public API's.
  • Fixed logging location on examples/run_examples.sh
  • Fixed issue with wolfTPM2_Init_ex handling of TPM2_Startup TPM_RC_INITIALIZE.

@dgarske dgarske requested a review from embhorn February 25, 2025 22:25
@dgarske dgarske assigned wolfSSL-Bot and unassigned dgarske Feb 25, 2025
@dgarske dgarske requested a review from tmael February 26, 2025 00:50
tmael
tmael approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@tmael tmael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dgarske, Unit tests pass with SWTPM simulator, confirming the TPM2_Startup initialization fix works.

@tmael tmael merged commit 0a463b3 into wolfSSL:master Feb 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmael tmael tmael approved these changes

@embhorn embhorn Awaiting requested review from embhorn

Assignees

@wolfSSL-Bot wolfSSL-Bot

@tmael tmael

@embhorn embhorn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgarske @tmael @wolfSSL-Bot @embhorn